Linux static build bustage with "undefined reference to mozilla::gfx::ConvertYCbCrToRGB32"

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
Graphics
--
critical
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Robert Kaiser, Assigned: standard8)

Tracking

Trunk
mozilla1.9.3a5
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
It looks like we have one more unfixed bustage from bug 560147 which is visible on Thunderbird and SeaMonkey trees, and that's in Linux static builds.

Error message:

../../mozilla/staticlib/libthebes.a(BasicImages.o): In function `mozilla::layers::BasicPlanarYCbCrImage::SetData(mozilla::layers::PlanarYCbCrImage::Data const&)':
BasicImages.cpp:(.text+0x34a): undefined reference to `mozilla::gfx::ConvertYCbCrToRGB32(unsigned char const*, unsigned char const*, unsigned char const*, unsigned char*, int, int, int, int, int, int, int, mozilla::gfx::YUVType)'
collect2: ld returned 1 exit status
gmake[5]: *** [seamonkey-bin] Error 1

Example logs:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1272532177.1272538047.7134.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1272552381.1272553494.10518.gz
(Reporter)

Updated

8 years ago
Severity: normal → critical
OS: All → Linux
(Assignee)

Comment 1

8 years ago
Note: my guess is that bug 562659 will fix this but I've not tried it out or looked in detail to be sure.
Depends on: 562659
(Reporter)

Comment 2

8 years ago
It's possible that bug 562659 would solve this, but a fast fix here could go a different way as well, so I decided to file different bugs.
(Assignee)

Comment 3

8 years ago
Created attachment 442645 [details] [diff] [review]
Possible fix

This is what Bas suggested to me on irc last night. Not perfect (i.e. bug 562659 would probably be better) but it may get us going again.

I've got this running on try server builds for Thunderbird + Firefox at the moment.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 4

8 years ago
I forgot, c-c try server can't do FF patches. Time to spin up a VM...
(Assignee)

Comment 5

8 years ago
Created attachment 442653 [details] [diff] [review]
The fix

This patch applies correctly and fixes the issue on static Thunderbird, and doesn't appear to break Firefox builds. I'm still compiling shared Thunderbird, but I expect it'll be fine, hence putting up for review.
Attachment #442645 - Attachment is obsolete: true
Attachment #442653 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #442653 - Flags: review? → review?(ted.mielczarek)
(Reporter)

Comment 6

8 years ago
With the patch, static and shared SeaMonkey (opt and debug for the latter), shared Thunderbird, and libxul Firefox compile fine for me on Linux! :)
Attachment #442653 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 7

8 years ago
Checked in: http://hg.mozilla.org/mozilla-central/rev/d917796fa333
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
(Assignee)

Updated

8 years ago
No longer depends on: 562659
You need to log in before you can comment on or make changes to this bug.