Closed Bug 562664 Opened 10 years ago Closed 10 years ago

Linux static build bustage with "undefined reference to mozilla::gfx::ConvertYCbCrToRGB32"

Categories

(Core :: Graphics, defect, critical)

All
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: kairo, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

It looks like we have one more unfixed bustage from bug 560147 which is visible on Thunderbird and SeaMonkey trees, and that's in Linux static builds.

Error message:

../../mozilla/staticlib/libthebes.a(BasicImages.o): In function `mozilla::layers::BasicPlanarYCbCrImage::SetData(mozilla::layers::PlanarYCbCrImage::Data const&)':
BasicImages.cpp:(.text+0x34a): undefined reference to `mozilla::gfx::ConvertYCbCrToRGB32(unsigned char const*, unsigned char const*, unsigned char const*, unsigned char*, int, int, int, int, int, int, int, mozilla::gfx::YUVType)'
collect2: ld returned 1 exit status
gmake[5]: *** [seamonkey-bin] Error 1

Example logs:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1272532177.1272538047.7134.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1272552381.1272553494.10518.gz
Severity: normal → critical
OS: All → Linux
Note: my guess is that bug 562659 will fix this but I've not tried it out or looked in detail to be sure.
Depends on: 562659
It's possible that bug 562659 would solve this, but a fast fix here could go a different way as well, so I decided to file different bugs.
Attached patch Possible fix (obsolete) — Splinter Review
This is what Bas suggested to me on irc last night. Not perfect (i.e. bug 562659 would probably be better) but it may get us going again.

I've got this running on try server builds for Thunderbird + Firefox at the moment.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
I forgot, c-c try server can't do FF patches. Time to spin up a VM...
Attached patch The fixSplinter Review
This patch applies correctly and fixes the issue on static Thunderbird, and doesn't appear to break Firefox builds. I'm still compiling shared Thunderbird, but I expect it'll be fine, hence putting up for review.
Attachment #442645 - Attachment is obsolete: true
Attachment #442653 - Flags: review?
Attachment #442653 - Flags: review? → review?(ted.mielczarek)
With the patch, static and shared SeaMonkey (opt and debug for the latter), shared Thunderbird, and libxul Firefox compile fine for me on Linux! :)
Attachment #442653 - Flags: review?(ted.mielczarek) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/d917796fa333
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
No longer depends on: 562659
You need to log in before you can comment on or make changes to this bug.