Closed
Bug 562740
Opened 14 years ago
Closed 14 years ago
Combine nsMenuFrame::DoLayout and nsPopupSetFrame::DoLayout
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
|
16.46 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
These two similar methods could be combined into one single method. Also, the scrollbar handling code isn't needed and causes a bug in menulists. To see this, create a menulist with more items than will fit onscreen. The scrollbar appears yet pushes the width of the popup out to accommodate it. Instead, it should appear inside the popup width. The test checks for this.
Attachment #442491 -
Flags: review?(roc)
Attachment #442491 -
Flags: review?(roc) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b0691a6db8d3
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Comment 2•9 years ago
|
||
Bug 1130400 part 1 corrects what seems like an oversight from the patch in this bug.
|
||
Updated•5 years ago
|
Assignee: nobody → enndeakin
|
||
Updated•5 years ago
|
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•