Closed Bug 562740 Opened 10 years ago Closed 10 years ago

Combine nsMenuFrame::DoLayout and nsPopupSetFrame::DoLayout

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
These two similar methods could be combined into one single method.

Also, the scrollbar handling code isn't needed and causes a bug in menulists. To see this, create a menulist with more items than will fit onscreen. The scrollbar appears yet pushes the width of the popup out to accommodate it. Instead, it should appear inside the popup width. The test checks for this.
Attachment #442491 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/b0691a6db8d3
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Depends on: 566154
Depends on: 634775
Bug 1130400 part 1 corrects what seems like an oversight from the patch in this bug.
Assignee: nobody → enndeakin
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in before you can comment on or make changes to this bug.