56275 - After changing Themes mail body for non-ascii messages is garbled

Status: RESOLVED WORKSFORME

(MailNews Core :: Internationalization, defect, P3)

Description

[marina]

**** observed with 2000-10-12 build ****
Steps to reproduce:
- go to Preferences and change Themes from Modern to classic;
- come back to Messenger;
- select a message (any: JA, French, Cyrillic);
//note: header in the thread and header in the message body are fine but the
body itself is garbled

Comment 1

[nhottanscp]

I can reproduce this with win32 branch build ID2000101108.
Work around is to create a new thread pane.

Comment 2

[marina]

Latin--2 languages are garbled in the thread as well (for Subject and sender 
name)

Comment 3

[marina]

adding rtm keyword, i think it's pretty serious

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 56277 has been marked as a duplicate of this bug. ***

Comment 5

[marina]

After switching Themes the Latin-2 entries in  Address Book are garbled. Naoki, 
do i leave as comments here or enter a new bug for AB? 

Comment 6

[msanz]

Frank, can you triage this bug?

Comment 7

[Katsuhiko Momoi]

marina, can you re-test this for the current build?

Comment 8

[Katsuhiko Momoi]

Mass change to bugs filed by marina --> QA contact to marina.
thanks!

Comment 9

[nhottanscp]

Adding mscott to cc, do you know any possibility that libmime might be affected
by the theme change?

Comment 10

[nhottanscp]

MIME sends UTF-8 to layout, so messenger notify it by setting a force charset.
But after the theme change, the force charset seems to be reset. So input to 
layout is not recognized as UTF-8.
If I open a message as a stand alone, the message is shown correctly.
Also if I set 'mCharsetInitialized' false manually (in debuger) the message is 
shown correctly because it forces a charset back to UTF-8.
Scott, please take a look at this.

void
nsMessenger::InitializeDisplayCharset()
{
  if (mCharsetInitialized)
    return;

  // libmime always converts to UTF-8 (both HTML and XML)
  if (mDocShell) 
  {
    nsAutoString aForceCharacterSet; 
aForceCharacterSet.AssignWithConversion("UTF-8");
    nsCOMPtr<nsIContentViewer> cv;
    mDocShell->GetContentViewer(getter_AddRefs(cv));
    if (cv) 
    {
      nsCOMPtr<nsIMarkupDocumentViewer> muDV = do_QueryInterface(cv);
      if (muDV) {
        muDV->SetForceCharacterSet(aForceCharacterSet.GetUnicode());
      }

      mCharsetInitialized = PR_TRUE;
    }
  }
}

Comment 11

[scottputterman]

marking nsbeta1-.  Need to get theme switching for message pane to work first.

Comment 12

[msanz]

Scott, I don't know about getting theme switching to work first, but this
problem seems serious with any theme change. Marina, can you comment on the bug?

Comment 13

[Scott MacGregor]

That's why we have a big warning when you switch themes which says "be sure to
close all mail windows". docshell's and such tend to become detached when you
switch themes. this bug should be marked a dup of that one.....we still have a
lot of theme switching work to do.

Comment 14

[Jaime Rodriguez, Jr.]

I think Scott is correct, the warning always shows up on-top for me. Please let
us know, if you see something different. Agree with the nsbeta1- for now.

Comment 15

[Jaime Rodriguez, Jr.]

Marina - If you and Jenn agree on MScott's message, that this is as designed, we 
should close this as invalid.

Comment 16

[marina]

the verification of this bug is blocked by bug 116038 though i don't think it is
happening in the latest builds

Comment 17

[buovjaga]

Based on the last old comments, I think this should be closed, so closing..