562876 - Addons manager rewrite removed brand.dtd reference, l10n builds still need that.

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Axel Hecht [:Pike]]

The current localizations of the addons manager code, aka, extensions.dtd reference &brandShortName; all over the place.

Now, the new strings in en-US don't anymore, thus the reference to brand.dtd was dropped, but the l10n-merged l10n files only add the new English strings, don't drop the obsolete ones.

Thus l10n builds break right now.

We should add an inclusion of brand.dtd back to extensions.xul, and file a follow up to remove it once we're not relying on l10n-merged builds anymore. Which might very well be extending into the stable release phase of this code.

The other way would be just to hardcode 
<!ENTITY brandShortName "UNUSED">
directly, might be better perf-wise.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I found this bug while trying to run one of the new l10n builds we triggered last night. We really need a working solution today. Given the problem above we should get this fixed asap.

Once this is fixed we need new l10n nightly builds (bug 562682).

Comment 2

[Axel Hecht [:Pike]]

It might be good enough to just rename the entities, bug 562877. IIRC, parsing errors in un-used entities don't break. Should be tested, though. You can verify that by adding a dummy entity referencing &brandShortName; in your local build.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Re-add brand.dtd

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Emergency bustage fix at:
https://hg.mozilla.org/mozilla-central/rev/254ea07099d2

Comment 5

[[:Aleksej]]

Works in linux-i686 eo 20100430064302:
Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre

Comment 6

[Axel Hecht [:Pike]]

Drats, we're having the same problem in the xbl binding, extensions.xml, http://hg.mozilla.org/mozilla-central/diff/bcd432fa0450/toolkit/mozapps/extensions/content/extensions.xml

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's the reason for bug 562894. Dave, could you jump in here while Blair is on his weekend?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Follow-up patch for extensions.xml

Dave, can we please get this into the tree, so we will have working l10n builds tomorrow? Thanks.

Comment 9

[Remko de Keijzer]

I've manually edited my extensions.xml adding the lines in the patch and bug 562894 is resolved by this editing.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In favor of the already checked-in patch on bug 562877 we have to back this out.

Comment 11

[Dave Townsend [:mossop]]

Fixed by bug 562877

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fa; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre (.NET CLR 3.5.30729)