562884 - Non-Firefox apps fail running test_fuel.js with "TypeError: AM_Cc['@mozilla.org/fuel/application;1'] is undefined"

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Mark Banner (:standard8)]

Non-Firefox apps will fail when running test_fuel.js due to:

/buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_extensionmanager/xpcshell/test_fuel.js:51: TypeError: AM_Cc['@mozilla.org/fuel/application;1'] is undefined

I can see several possibilities for fixes:

- List each application in the test
- Harmonise the different ids into one, so that each application used the same.
- Move test_fuel.js under browser/ and maybe duplicate for each app.
- Use the build system to generate a function to get the equivalent of fuel for each app.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mmh, is it a left-over from the patch on bug 552731?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Mmh, is it a left-over from the patch on bug 552731?

I wouldn't have said a left-over. Incorrect assumption in writing the test maybe.

Comment 3

[Dave Townsend [:mossop]]

So FUEL isn't always present, when it is present does it sometimes have different contract IDs?

I could probably look up the contract ID in the category manager registration for the Application global object and go from there.

Comment 4

[Mark Banner (:standard8)]

Thunderbird's id is: "@mozilla.org/steel/application;1"

SeaMonkey's id is: "@mozilla.org/smile/application;1"

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This looks up the Application contract ID in the category manager and exits if it is not found or if whatever is there is not an extIApplication.

Comment 6

[Dave Townsend [:mossop]]

http://hg.mozilla.org/projects/addonsmgr/rev/d2bf8e542e98

Comment 7

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/2a6fde3b2211

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed by checkin and a green test-run.