562935 - update add-ons [text/link] is difficult to read

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre ID:20100430040256

repro:
open FF
open add-ons manager
find a way to manually update

expected:
something detectable with the naked eye ;-)

result:
a hard to find link.

Comment 1

[Dão Gottwald [:dao]]

Does this mix -moz-nativehyperlink in foreground with hardcoded colors in the background?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This will completely change with the work on bug 562622. See the design mockups attached there.

Blair, marking as WONTFIX?

Comment 3

[Dão Gottwald [:dao]]

My -moz-nativehyperlink question applies to all links in EM UI.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #3)
> My -moz-nativehyperlink question applies to all links in EM UI.

That will be fixed by bug 563565 - which will be sorted out once we have a more final visual design (current colors are temporary).

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #2)
> This will completely change with the work on bug 562622. See the design mockups
> attached there.
> 
> Blair, marking as WONTFIX?

Since removing the link is a perfectly valid solution to this bug, the right work flow is to mark this fixed when the link has been removed. However, attachment 442478 [details] still contains links (fourth and fifth step).

Comment 6

[Tyler Downer [He/Him]]

This text is not even there anymore. Close?

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> This text is not even there anymore. Close?

Is it gone throughout all states? (see attachment 442478 [details])

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #6)
> This text is not even there anymore. Close?

The specific text that's shown in the screenshot is gone, but there are still other cases. And yes, they still use -moz-nativehyperlinktext on top of hardcoded background colors (soon to be textures).

Comment 11

[Dave Townsend [:mossop]]

Fixed by bug 601022, file any remaining issues separately

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marking as verified fixed with builds on all platforms like Mozilla/5.0 (X11;
Linux i686; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre ID:20101125030318

Now we are showing "View Available Updates" at the left side of the utility button once updates are available. The link looks good to me now.