562954 - switch "Remove" and "Disable" buttons for consistency

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Nikita Popov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100429 Minefield/3.7a5pre (.NET CLR 3.5.30729)
Build Identifier: 

In about:addons the buttons currently have this order:
Remove Disable
It would be better to switch them, so one gets:
Disable Remove

This way the remove buttons will always be in one row. (Right now it is not this way, because some add-ons are already disabled and therefore the disable button is missing, so the remove button takes the place of the disable-button.


Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sounds reasonable. Right now it looks a bit shuffled. Asking for ux feedback.

Comment 2

[dickvl]

I have extensions that are installed globally for all Firefox versions in the .mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384} folder (I'm on Linux).
See https://developer.mozilla.org/en/Installing_extensions

Those extensions can't be uninstalled, but can be disabled, so they do not have a Remove button, but do have a Disable button.
Currently the Disable/Enable buttons line up and switching the two buttons would in this case cause inconsistency.
So both have their advantages and disadvantages.

Comment 3

[Nikita Popov]

It will much more often occur that add-ons cannot be disabled than cannot be removed.

I think very few of the Firefox end users would want to install extensions globally using the .xpi files. Some 99.9% will rely on the add-on installer of Firefox (Click here, click there, restart and you're done.)

Much more users will experience incompatible add-ons being disabled in new versions of Firefox.

Comment 4

[Nikita Popov]

This is already fixed in trunk, thus resolving as worksforme.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The final steps have been checked in with bug 590201. Marking as verified fixed.