562995 - Addons mgr error console msg during ext update

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[aja+bugzilla]

Error: document.getElementById("updates-nonefound") is null
Source file: chrome://mozapps/content/extensions/extensions.js
Line: 317

Comment 1

[aja+bugzilla]

That's in this section of code:

        function updateStatus() {
          if (pendingChecks > 0)
            return;
          document.getElementById("updates-progress").hidden = true;

          if (numUpdated == 0) {
            document.getElementById("updates-checkNow").hidden = false;
            document.getElementById("updates-nonefound").hidden = false;
            return;
          }


Perhaps should be noneFound ?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, see:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.xul#143

You wanna write the patch? Or don't you have the capabilities for now?

Comment 3

[aja+bugzilla]

Well....it'd be my 1st patch.....but why don't you go ahead...will be a lot quicker

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 5

[Dave Townsend [:mossop]]

I would like to hold off on non-urgent checkins right now until I know we don't have to back everything back out.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dave, would a whiteboard entry help instead? If yes please set it. I don't wanna forget about this bug.

Comment 7

[Dave Townsend [:mossop]]

Landed on the branch: http://hg.mozilla.org/projects/addonsmgr/rev/30f9fbb91c48

Comment 8

[Dave Townsend [:mossop]]

http://hg.mozilla.org/mozilla-central/rev/f0f2c257757e

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100517 Minefield/3.7a5pre