563020 - Button text wraps in add-on listings

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot of buttons in search results

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/z/en-US/firefox/search/?q=&cat=all&appid=1&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=
2.Notice the a)Continue to Download b)Download for MacOSX buttons


observed behavior:
The arrow mark in the button wraps making the button look very big..See screenshot.

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot 2

Comment 2

[krupa raj[:krupa]]

This also happens on /extensions page- https://preview.addons.mozilla.org/z/en-US/firefox/extensions/?sort=name

Comment 3

[Potch [:potch]]

2 possible solutions:

We could simply make the button's parent wider, which will cure the wrap. This doesn't solve the problem that the arrow could wrap. I think it would also be a good idea to change strings that end in a single symbol character so that the symbol does not wrap on its own, eg:

'Continue to Download →' becomes 'Continue to Download →'

note we can't really prevent all buttons from wrapping, because things get funky with the overflow, but this is likely a way to get them to wrap in a more visually appealing and controlled way. 

Thoughts?

Comment 4

[Justin Scott [:fligtar]]

My request for button wrapping in order of priority is:
1. Arrows should not wrap by themselves
2. English strings should be on one line if at all possible
3. Long strings should wrap

Comment 5

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/2c8361af

Comment 6

[krupa raj[:krupa]]

verified at https://preview.addons.mozilla.org/en-US/firefox/search/?q=double+check&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced= and https://preview.addons.mozilla.org/en-US/firefox/extensions/?page=2

Strings like "Continue to Download" has not been translated in languages like he,ja etc.Will be filing new bugs,if this issue is not noticed in any other locale.

Calling this verified for en-US