563117 - Clicking pane selector of selected type while staying in details view should return to add-on list

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100430 Minefield/3.7a5pre RTSE/1.2.0.20100406
Build Identifier: 

In the EM rewrite, if you're looking at a detailed view of an extension in the right column of the addon manager, clicking "Extensions" from the left column does nothing. It should (in my opinion) restore the full list of extensions, just like the "Back to Extensions" button at the top of the page.

If you chose some other item from the left column, and then reselect "Extensions", it will show the list of extensions, not the detailed view.

Reproducible: Always

Comment 1

[Dave Townsend [:mossop]]

Spoke with Boriss over IRC, we should do this.

Comment 2

[Ben Parr [:bparr]]

Attachment: Simple patch by adding a click event listener

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 446095 [details] [diff] [review]
Simple patch by adding a click event listener

This is great work and does fix the bug. There is one minor change that you should do to improve this. Once you've done that, re-attach the patch and we can get it checked in.

>+    this.node.addEventListener("click", function(aEvent) {
>+      var selectedItem = self.node.selectedItem;
>+      if (aEvent.target.localName == "richlistitem" &&
>+          aEvent.target.id == selectedItem.id) {

Here there is no need to compare the ID of the elements, instead you should just compare that event.target == selectedItem.

Comment 4

[Ben Parr [:bparr]]

Attachment: Updated patch

Included Mossop's change.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 446307 [details] [diff] [review]
Updated patch

Perfect, thanks

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as http://hg.mozilla.org/mozilla-central/rev/009a59650292

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100526 Minefield/3.7a5pre

This is testable by an automated test. Blair, would that invalidate the in-litmus flag?