563123 - use js::HashMap for JSCodeGenerator::constList

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

This is good for 549143 when values don't fit in a void*.  Also it would be nice to move away from atomized doubles.

Comment 1

[Igor Bukanov]

Comment on attachment 442885 [details] [diff] [review]
patch

>diff --git a/js/src/jsemit.cpp b/js/src/jsemit.cpp
>@@ -1639,20 +1641,19 @@ LookupCompileTimeConstant(JSContext >+            if (JSConstMap::Ptr p = cg->constMap.lookup(atom)) {
>+                JS_ASSERT(p->value != JSVAL_HOLE);
>+                *vp = p->value;
>                 return JS_TRUE;

...

>+typedef js::HashMap<JSAtom *, jsval> JSConstMap;

> struct JSCodeGenerator : public JSTreeContext
> {

Nit: put JSConstMap typedef into JSCodeGenerator. That would lengthen somewhat the lookup statement, but that perhaps suggests to have an alternative lookup method like bool lookup(Value &)

Comment 2

[Luke Wagner [:luke]]

(In reply to comment #1)
Thanks.  'JSCodeGenerator::ConstMap p = cg->constMap.lookup(atom);' still fits on one line, so, to keep the patch small, I didn't method-ize anything.

http://hg.mozilla.org/tracemonkey/rev/c6857d0b1e9f

Comment 3

[Luke Wagner [:luke]]

Missed an init.
http://hg.mozilla.org/tracemonkey/rev/c6857d0b1e9f

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/c6857d0b1e9f