563159 - updater fails because application exe is still running

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mark Smith [:mcs]]

Attachment: proposed fix (always sleep briefly)

On Windows, the updater intermittently fails (at least on one of my test WinXP computers) and causes the Mozilla application to display this message:

  The update could not be installed.  Please make sure there are no
  other copies of <APP> running on your computer, and then restart
  <APP> to try again.

Exiting and restarting does allow the update to succeed, although restarting from the Tools menu (Apply Update Now) often fails with the above message too.

This is a spin off from bug 466778 comment 15.

I am attaching a patch that seems to fix the problem, which appears to be caused by a delay between the moment Windows says a process has exited and when the EXE has actually been released.

Thank you to Robert Strong for his guidance.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 442919 [details] [diff] [review]
proposed fix (always sleep briefly)

I'll check this in next chance I have

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/98901ab12e04

minusing in-testsuite and in-litmus... this is a rare condition that we can't test for