TM: "Assertion failure: r == MONITOR_ERROR," with parse

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: gkw, Assigned: luke)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
assertion, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
(function() {
  for (var a = 0; a < 2; a++) {
    parse("\uF002")
  }
})()

asserts js debug shell on TM tip with -j at Assertion failure: r == MONITOR_ERROR, at ../jsops.cpp:906

This still asserts even with the patch from bug 563120 applied.
(Reporter)

Comment 1

8 years ago
autoBisect shows this is probably related to bug 560798:

The first bad revision is:
changeset:   41270:04b98e71bc55
user:        Luke Wagner
date:        Mon Apr 26 09:30:06 2010 -0700
summary:     Bug 560798 - propagate errors from deep-aborted natives (r=gal)

However, this patch might just merely have exposed the problem rather than cause it..
Blocks: 560798
(Assignee)

Comment 2

8 years ago
Created attachment 442938 [details] [diff] [review]
patch

This is the same type of error as bug 563120; this time its Parse() in shell/js.cpp.  Simple fix.
Assignee: general → lw
Status: NEW → ASSIGNED
Attachment #442938 - Flags: review?(cdleary)
Comment on attachment 442938 [details] [diff] [review]
patch

Schwoops. Thanks for the fix!
Attachment #442938 - Flags: review?(cdleary) → review+

Comment 4

8 years ago
++luke for aggressive assertions all over the place
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/tracemonkey/rev/5ce433326103
Whiteboard: fixed-in-tracemonkey

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/5ce433326103
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.