563177 - No tooltip shown for Calendar and Tasks toolbar button

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning/1.0b2pre with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.5pre) Gecko/20100501 Lanikai/3.1pre

Steps To Reproduce:
1. Select menu View > Toolbars > Customize...
2. Add Calendar and Tasks button to the toolbar
3. Move mouse over toolbar buttons

Actual Results:
No tooltip shown for Calendar and Tasks toolbar button.

Expected Results:
A tooltip is shown for Calendar and Tasks toolbar button like it's done for Thunderbird buttons.

Comment 1

[Felix Möller]

Attachment: screenshot of issue

I can reproduce this

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Add tooltips

This patch gives the same tooltips like the lightning buttons on the tab bar. If you want a more descriptive text I can add it. Then please give me an example what you want.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I think making it be the same text is quite pointless. How about

"Switch to the calendar tab"
"Switch to the tasks tab"

?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Add tooltips v2

Tooltips with your proposal. I've also changed the tabmail-buttons to use this tooltips.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 580797 [details] [diff] [review]
Add tooltips v2

r=philipp

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Add tooltips v3

Oops, found the tabs are using the tooltip text as title and this doesn't look so good. Added now the attribute title to use for the tab title.

Comment 7

[Richard Marti (:Paenglab)]

Pushed to comm-aurora http://hg.mozilla.org/comm-central/rev/17574f0443d1

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Could you back this out of aurora? Strings are frozen on aurora and although thats unfortunate, we'd have to discuss this with localizers first before changing.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Oh fun, I just read the first part of your comment :-)

Comment 10

[Richard Marti (:Paenglab)]

Sorry, copy/paste error :-(