563190 - XForms crash with Firefox release build

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Philipp Wagner [:imphil]]

Latest XForms builds work fine with the Firefox version it was compiled with, but crash with a released Firefox build.

The last working nightly was 2010-04-13:
http://philipp.wagner.name/mozilla-xforms/builds/nightly-1.9.2/2010041322/xforms-merged_2010-04-13.xpi
The next one crashes when loading a page with a form on it:
http://philipp.wagner.name/mozilla-xforms/builds/nightly-1.9.2/2010041422/xforms-merged_2010-04-14.xpi
(reproducible on Windows and linux32, this pretty much rules out changes to the build system)

There seems to be no XForms commit in that timeframe, and I was not yet able to identify a Firefox/Gecko commit that caused this. 

The problem seems to be independent of the Firefox version (3.6.0 is the same as 3.6.3).

I'm actually rather confused right now ...

Comment 1

[Philipp Wagner [:imphil]]

btw, on Windows the debugger says
nsXFormsModelElement.cpp:166
 nsCOMPtr<nsIDocument> doc = do_QueryInterface(domDoc);
returns a null pointer for doc. 
Could have commit 34075:5af70883c1de (bug 489127) caused this?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yes, bug 489127 looks very suspicious and wrong for release branch.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> btw, on Windows the debugger says
> nsXFormsModelElement.cpp:166
>  nsCOMPtr<nsIDocument> doc = do_QueryInterface(domDoc);
> returns a null pointer for doc. 

that's not possible until domDoc is null

> Could have commit 34075:5af70883c1de (bug 489127) caused this?

it's not possible since bug 489127 was landed on 1.9.2.5. We build xforms for 1.9.2.3.

(In reply to comment #0)
> Latest XForms builds work fine with the Firefox version it was compiled with,
> but crash with a released Firefox build.

That's a reason. nsIDocument  has been changed (as you pointed above). You should install xforms exactly on the same firefox version you've built xforms for.

It sounds this bug is invalid.

Comment 4

[timeless]

your packaging should prevent people from doing this...

Comment 5

[Philipp Wagner [:imphil]]

fixed with bug 563235.