Closed Bug 563200 Opened 14 years ago Closed 14 years ago

fix deprecated conversion and comparison between signed and unsigned in testplugin/nptest.cpp

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

modules/plugin/test/testplugin/nptest.cpp:
 In function ‘char* NP_GetPluginVersion()’:
531: warning: deprecated conversion from string constant to ‘char*’

 In function ‘char* NP_GetMIMEDescription()’:
541: warning: deprecated conversion from string constant to ‘char*’

 In function ‘NPError NP_GetValue(void*, NPPVariable, void*)’:
549: warning: deprecated conversion from string constant to ‘char*’
552: warning: deprecated conversion from string constant to ‘char*’

 In function ‘NPError NP_Initialize(NPNetscapeFuncs*)’:
593: warning: comparison between signed and unsigned integer expressions

 In function ‘NPError NP_Shutdown()’:
639: warning: comparison between signed and unsigned integer expressions

So, the conversions are because of an npapi design botch
Attached patch proposalSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #442955 - Flags: review?(jst)
Attachment #442955 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/439fe191d5c5
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: