Closed
Bug 563219
Opened 14 years ago
Closed 14 years ago
Remove @BINPATH@ from removed-files.in
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(thunderbird3.1 rc1-fixed)
RESOLVED
FIXED
Thunderbird 3.3a1
| Tracking | Status | |
|---|---|---|
| thunderbird3.1 | --- | rc1-fixed |
People
(Reporter: philor, Assigned: philor)
Details
Attachments
(2 files)
|
758 bytes,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
|
744 bytes,
patch
|
standard8
:
review+
standard8
:
approval-thunderbird3.1+
|
Details | Diff | Splinter Review |
I didn't actually go so far as checking what the @BINPATH@ in removed-files.in is doing to us - best case, it's undefined and resulting in "", worst case, it has a value and we haven't been removing nsINIProcessor.js on downgrades to 1.9.2 and didn't remove xpinstall.dll while the EM rewrite was in. Either case, the 800 lines which do not start with it say that we don't need it.
Attachment #442973 -
Flags: review?(bugzilla)
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #442974 -
Flags: review?(bugzilla)
|
||
Updated•14 years ago
|
Attachment #442973 -
Flags: review?(bugzilla) → review+
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 442974 [details] [diff] [review] comm-192, removed the @BINPATH@ r+a=Standard8
Attachment #442974 -
Flags: review?(bugzilla)
Attachment #442974 -
Flags: review+
Attachment #442974 -
Flags: approval-thunderbird3.1+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/comm-central/rev/9ef99d67d2d1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/releases/comm-1.9.2/rev/319ffed5f86f
status-thunderbird3.1:
--- → rc1-fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•