Closed
Bug 563226
Opened 14 years ago
Closed 11 years ago
warning: comparison between signed and unsigned integer expressions in nsHTMLFramesetFrame::RecalculateBorderResize()
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 653295
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
14.12 KB,
patch
|
zwol
:
review+
timeless
:
review-
|
Details | Diff | Splinter Review |
layout/generic/nsFrameSetFrame.cpp: In member function ‘void nsHTMLFramesetFrame::RecalculateBorderResize()’: 1357: warning: comparison between signed and unsigned integer expressions
i know, it's just one warning, but i really didn't like the variable types :)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 442983 [details] [diff] [review] proposal Variables holding namespace IDs have to remain signed, because kNameSpaceID_UNKNOWN is -1. Please file a bug on turning the mChildTypes constants in nsHTMLFramesetFrame into a proper enumeration. Otherwise, looks good.
Attachment #442983 -
Flags: review?(zweinberg) → review+
Comment on attachment 442983 [details] [diff] [review] proposal i think i'm still working on this one
Attachment #442983 -
Flags: review-
|
||
Updated•13 years ago
|
Whiteboard: [build_warning]
|
|
||
Updated•13 years ago
|
Blocks: buildwarning
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•