Closed Bug 563226 Opened 10 years ago Closed 7 years ago

warning: comparison between signed and unsigned integer expressions in nsHTMLFramesetFrame::RecalculateBorderResize()

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, minor)

x86_64
macOS
defect
Not set
minor

Tracking

()

RESOLVED DUPLICATE of bug 653295

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

layout/generic/nsFrameSetFrame.cpp: In member function ‘void nsHTMLFramesetFrame::RecalculateBorderResize()’:
1357: warning: comparison between signed and unsigned integer expressions
Attached patch proposalSplinter Review
i know, it's just one warning, but i really didn't like the variable types :)
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #442983 - Flags: review?(zweinberg)
Comment on attachment 442983 [details] [diff] [review]
proposal

Variables holding namespace IDs have to remain signed, because kNameSpaceID_UNKNOWN is -1.

Please file a bug on turning the mChildTypes constants in nsHTMLFramesetFrame into a proper enumeration.

Otherwise, looks good.
Attachment #442983 - Flags: review?(zweinberg) → review+
Comment on attachment 442983 [details] [diff] [review]
proposal

i think i'm still working on this one
Attachment #442983 - Flags: review-
Whiteboard: [build_warning]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 653295
Product: Core → Core Graveyard
Component: Layout: HTML Frames → Layout: Images
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.