563259 - TraceMonkey Shark builds broken since May 01

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Eg:
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1272796320.1272797032.24308.gz

Something in this range of checkins:
http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=990192b0e052&tochange=b414c98f9030

Bug 562144 ?

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

On it -- must be some relation between --enable-shark and the dtrace hooks I didn't notice.

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Fix build break.

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/c63d6b20c590

I'll make sure it goes through before marking as fixed-in-tracemonkey, but it works on my 10.5 and Linux test machines.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

It's no longer listed as burning on tinderbox. I don't know where it went (she shark build isn't even listed there anymore), but I'll assume it worked.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

It only runs once a day, with the other nightly builds, so falls off the waterfall after 12 hours. I've forced a new build to verify the fix. Thanks for the quick work.

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to comment #5)

Thanks for finding it!

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Broken in a different way now:

g++-4.2  -fno-rtti ... -o libmozjs.dylib  jsapi.o ...
Undefined symbols:
  "_jsdtrace_execute_start", referenced from:
      _js_Execute in jsinvoke.o
  "_jsdtrace_function_return", referenced from:
      _js_Interpret in jsinterp.o
      _js_Interpret in jsinterp.o
      _js_Invoke in jsinvoke.o
  "_jsdtrace_execute_done", referenced from:
      _js_Execute in jsinvoke.o
  "_jsdtrace_function_rval", referenced from:
      _js_Interpret in jsinterp.o
      _js_Interpret in jsinterp.o
      _js_Invoke in jsinvoke.o
  "_jsdtrace_object_create", referenced from:
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsapi.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsarray.o
      _js_NewDateObjectMsec in jsdate.o
      _JS_NewSystemObject in jsdbgapi.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsexn.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsfun.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinterp.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinvoke.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsiter.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsobj.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in json.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsregexp.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jstypedarray.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsxml.o
  "_jsdtrace_object_finalize", referenced from:
      void FinalizeArenaList<JSObject, &(FinalizeObject(JSContext*, JSObject*, unsigned int))>(JSContext*, unsigned int)in jsgc.o
      void FinalizeArenaList<JSObject, &(FinalizeHookedObject(JSContext*, JSObject*, unsigned int))>(JSContext*, unsigned int)in jsgc.o
      _js_GC in jsgc.o
      _js_GC in jsgc.o
  "_jsdtrace_object_create_start", referenced from:
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsapi.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsarray.o
      _js_NewDateObjectMsec in jsdate.o
      _JS_NewSystemObject in jsdbgapi.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsexn.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsfun.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinterp.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinvoke.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsiter.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsobj.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in json.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsregexp.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jstypedarray.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsxml.o
  "_jsdtrace_object_create_done", referenced from:
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsapi.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsarray.o
      _js_NewDateObjectMsec in jsdate.o
      _JS_NewSystemObject in jsdbgapi.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsexn.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsfun.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinterp.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsinvoke.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsiter.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsobj.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in json.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsregexp.o
      js::NewObject(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jstypedarray.o
      js::NewObjectWithGivenProto(JSContext*, JSClass*, JSObject*, JSObject*, unsigned long)in jsxml.o
  "_jsdtrace_function_info", referenced from:
      _js_Interpret in jsinterp.o
      _js_Interpret in jsinterp.o
      _js_Invoke in jsinvoke.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

This has also spread to mozilla-central since tracemonkey merged there.

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to comment #7)
> Broken in a different way now:

Hmmm -- did that subsequent build you kicked off work in comment 5? Fix is most likely already committed via bug 563870.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

The May 2nd build on rev c63d6b20c590 looks like it failed in the same way as comment #7.

Comment 10

[Ginn Chen]

Attachment: fix bustage on Solaris

Comment 11

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 443820 [details] [diff] [review]
fix bustage on Solaris

Ginn, thanks for the patch! We happened to put a fix into tracemonkey that covers these changes already in bug 563870 which has now been merged into mozilla-central  ala http://hg.mozilla.org/mozilla-central/rev/c052b348a626#l1.85 -- LMK if you have any questions!

Comment 12

[Chris Leary [:cdleary] (not checking bugmail)]

nthomas, can you confirm unbustage so we can close as resolved?

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

0f5867192284 for the May 06 nightly was green. Please merge to mozilla-central.

Comment 14

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to comment #13)
> 0f5867192284 for the May 06 nightly was green. Please merge to mozilla-central.

nthomas, do you mean there's some additional merging that must be done on top of the one mentioned in comment 11?

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Sorry, failed to read that comment properly - no action needed.