563294 - Failure to build with gcc 4.4 in c++0x mode

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Mike Hommey [:glandium]]

This is what I get when building 1.9.2.4 build2 with gcc 4.4 in c++0x mode:

In file included from /usr/include/c++/4.4/memory:83,
                 from ../../dist/system_wrappers/memory:3,
                 from ../../ipc/chromium/src/base/thread_collision_warner.h:8,
                 from ../../ipc/chromium/src/base/ref_counted.h:9,
                 from ../../ipc/chromium/src/base/message_pump.h:8,
                 from ../../ipc/chromium/src/base/message_loop.h:14,
                 from nsXPComInit.cpp:152:
/usr/include/c++/4.4/bits/shared_ptr.h: In member function 'virtual void* std::_Sp_counted_deleter<_Ptr, _Deleter, _Alloc, _Lp>::_M_get_deleter(const std::type_info&)':
/usr/include/c++/4.4/bits/shared_ptr.h:146: error: cannot use typeid with -fno-rtti
/usr/include/c++/4.4/bits/shared_ptr.h: In member function 'virtual void* std::_Sp_counted_ptr_inplace<_Tp, _Alloc, _Lp>::_M_get_deleter(const std::type_info&)':
/usr/include/c++/4.4/bits/shared_ptr.h:204: error: cannot use typeid with -fno-rtti
/usr/include/c++/4.4/bits/shared_ptr.h: In constructor 'std::__shared_ptr<_Tp, _Lp>::__shared_ptr(std::_Sp_make_shared_tag, _Alloc, _Args&& ...)':
/usr/include/c++/4.4/bits/shared_ptr.h:861: error: cannot use typeid with -fno-rtti
/usr/include/c++/4.4/bits/shared_ptr.h: In function '_Del* std::get_deleter(const std::__shared_ptr<_Tp2, _Lp>&)':
/usr/include/c++/4.4/bits/shared_ptr.h:1005: error: cannot use typeid with -fno-rtti

Replacing the #include <memory> with #include <memory.h> in ipc/chromium/src/base/thread_collision_warner.h seems to be enough.

Arguably, gcc should maybe not use typeid it this header...

Comment 1

[Mike Hommey [:glandium]]

Attachment: Replace memory with memory.h

As you said on irc you were fine with that approach... I'm just wondering how that should be incorporated. For example, would a patch file in ipc/ be good ? or should the pull-chromium.py script modified ?

Comment 2

[Benjamin Smedberg]

Comment on attachment 443306 [details] [diff] [review]
Replace memory with memory.h

We've basically forked the chromium code, we don't sync with upstream.

Comment 3

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/318cc56de289

Comment 4

[Mike Hommey [:glandium]]

Would you want this on 1.9.2, too ?