Closed Bug 563372 Opened 12 years ago Closed 12 years ago

nsICanvasRenderingContextWebGL.idl shouldn't define GL_TRUE or GL_FALSE

Categories

(Core :: Canvas: WebGL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

If <OpenGL/OpenGL.h> is included before "nsICanvasRenderingContextWebGL.h" on Mac OS X, the following build error happens:

In file included from /Volumes/MozillaBuilds/10_6/ff_193_debug_32/dom/base/nsDOMClassInfo.cpp:441:
../../dist/include/nsICanvasRenderingContextWebGL.h:738: error: expected identifier before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:738: error: expected `}' before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:738: error: expected unqualified-id before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:740: error: expected identifier before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:740: error: expected `}' before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:740: error: expected unqualified-id before numeric constant
../../dist/include/nsICanvasRenderingContextWebGL.h:740: error: expected declaration before ‘}’ token
Attached patch fix v1.0Splinter Review
I'm not sure this is the right thing to do but it seems to work for my purposes, I'll need to tryserver it though.
Attachment #443121 - Flags: review?(vladimir)
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b69260e4687e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.