Closed Bug 563381 Opened 14 years ago Closed 14 years ago

plugin-container.exe needs app user model id synced

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 3 obsolete files)

Rob brought this up - not a huge deal now since the container currently only creates full screen windows, but in time it will become an issue.
Does this also affect the volume control mixer on Win7?
(In reply to comment #1)
> Does this also affect the volume control mixer on Win7?

From the comments in bug 441197, sounds like it's a bit different.
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: nobody → jmathies
Attachment #443365 - Flags: review?(benjamin)
Comment on attachment 443365 [details] [diff] [review]
patch v.1

>diff --git a/dom/plugins/PPluginModule.ipdl b/dom/plugins/PPluginModule.ipdl

>+  // Win specific, pass the taskbar window grouping id to the plugin
>+  // container.
>+  rpc SetTaskbarGroupId(nsString aId)
>+    returns (NPError rv);

Why is this RPC, and why does it return an error code? Can't this just be async SetTaskbarGroupId(nsString aId)?

>diff --git a/dom/plugins/PluginModuleChild.cpp b/dom/plugins/PluginModuleChild.cpp

>+#ifdef XP_WIN
>+const PRUnichar kShellLibraryName[] =  L"shell32.dll";
>+#endif

nit, static const


>+    if (!funcAppUserModelID) {
>+        ::FreeLibrary(hDLL);
>+        return true;
>+    }

can you switch this "if" so that the inner block is the success condition? That way you don't have to repeat the FreeLibrary call.

r=me with those changes
Attachment #443365 - Flags: review?(benjamin) → review+
Attached patch patch v.2 (obsolete) — Splinter Review
Updated. Bent pointed out that the original patch would only apply to plugins, so I've reworked this so that the id passes over the command line, and is registered right after the process is spawned.
Attachment #443365 - Attachment is obsolete: true
Attachment #443438 - Flags: review?(benjamin)
Attached patch patch v.2 (obsolete) — Splinter Review
- minor update, nsIWinTaskbarInfo was combined into nsIWinTaskbar in the patch for bug 505925.
Attachment #443438 - Attachment is obsolete: true
Attachment #443921 - Flags: review?(benjamin)
Attachment #443438 - Flags: review?(benjamin)
Attached patch patch v.2Splinter Review
added missing platform ifdef'ing in nsEmbedFunctions.cpp.
Attachment #443921 - Attachment is obsolete: true
Attachment #444175 - Flags: review?(benjamin)
Attachment #443921 - Flags: review?(benjamin)
Comment on attachment 444175 [details] [diff] [review]
patch v.2

Seems like the #define for NS_TASKBAR_CONTRACTID should be in a header somewhere so you don't have to repeat it in GeckoChildProcessHost.cpp
Attachment #444175 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/fa64c4c8cbab
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 569500
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: