563431 - Update Log Configuration in Code to Use LOG_LOCAL4 Facility

Status: RESOLVED FIXED

(Websites :: plugins.mozilla.org, defect)

Description

[Michael Coates [:mcoates] (acct no longer active)]

The log configuration needs to be updated to use "LOG_LOCAL4". This configuration will allow the syslog entries to be directed to the security integration manager.

http://viewvc.svn.mozilla.org/vc/projects/plugindir/trunk/modules/cef_logging/helpers/cef_logging.php?view=markup

Line 34:
openlog(self::$product, LOG_ODELAY, LOG_AUTHPRIV); 

Should be changed to use 'LOG_LOCAL4' instead of self:$product.  I imagine a new configuration variable within Kohana::config would make the most sense.

Note: We don't want to just change self::$product in the config. We need that to stay set to 'plugindir' since this is used within the CEF formatted log entries.

Comment 1

[Les Orchard [:lorchard]]

Looks like the 3rd parameter of openlog() is the facility (currently LOG_AUTHPRIV):

http://us2.php.net/manual/en/function.openlog.php

Is that actually what you want changed, instead of the 1st parameter (ie. $ident)?

Comment 2

[Michael Coates [:mcoates] (acct no longer active)]

Yes, good catch. The 3rd parameter is where it should go. So LOG_LOCAL4 instead of LOG_AUTHPRIV.

Comment 3

[Les Orchard [:lorchard]]

Cool... just checked in as r66737, should update on staging in 15-20 min if memory serves. (IT has an auto-update from SVN trunk running there on a cronjob task)

Comment 4

[Michael Coates [:mcoates] (acct no longer active)]

It looks like r66737 creates the new variable "self::$syslog_facility" but isn't using that within the openlog call:

Line 35 of cef_logging.php
 openlog(self::$product, LOG_ODELAY, LOG_AUTHPRIV); 


Or am I not seeing something?

Comment 5

[Les Orchard [:lorchard]]

(In reply to comment #4)
> Or am I not seeing something?

Oops - it's me who didn't see something! :) Should be fixed in r66738