Closed Bug 563517 Opened 14 years ago Closed 14 years ago

cuddlefish.packaging.PackageNotFoundError could be more helpful

Categories

(Add-on SDK Graveyard :: General, defect)

x86
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: asqueella, Unassigned)

Details

Attachments

(1 file)

Attached patch draft patchSplinter Review
Here I am again complaining about unhelpful error messages. I got into a state where I had a package depending on another package that wasn't in the jetpack install. The error I got was:

(jetpack-sdk)~/dev/jetpack-sdk$ cfx testall
Testing all available packages: nsjetpack, jetpack-core, test, test-harness, development-mode.
Traceback (most recent call last):
  File "/Users/nickolay/dev/jetpack-sdk/bin/cfx", line 6, in <module>
    cuddlefish.run()
  File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/__init__.py", line 260, in run
    test_all_packages(env_root, defaults=options.__dict__)
  File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/__init__.py", line 188, in test_all_packages
    defaults=defaults)
  File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/__init__.py", line 380, in run
    deps = packaging.get_deps_for_targets(pkg_cfg, targets)
  File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/packaging.py", line 169, in get_deps_for_targets
    raise PackageNotFoundError(dep)
cuddlefish.packaging.PackageNotFoundError: misc

I think it could have been at least
cuddlefish.packaging.PackageNotFoundError: misc (required by 'test')

A simple patch is attached, I don't pretend to be a python guru, so feel free to fix it up as needed.
Attachment #443214 - Flags: review?(avarma)
Awesome, thanks for the patch!

Pushed:

  Bug 563517 - cuddlefish.packaging.PackageNotFoundError could be more helpful
Nickolay_Ponomarev
http://hg.mozilla.org/labs/jetpack-sdk/rev/4fe6d70860e8933c9de9eedf212387453be3d460
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
Comment on attachment 443214 [details] [diff] [review]
draft patch

Review of attachment 443214 [details] [diff] [review]:
-----------------------------------------------------------------

I guess I actually pushed this 4 years ago but never actually r+'d it, so doing that now!
Attachment #443214 - Flags: review?(avarma) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: