563524 - Developers should not be allowed to navigate to public listing of an incomplete add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/en-US/developers/addons
2.Click the name of one your Incomplete add-on

expected result:
Names of incomplete add-ons are not click-able and they do not link to the non-existent public listing page

actual result:
404 page ensues on clicking the name of an incomplete add-on

Comment 1

[Wil Clouser [:clouserw]]

This is just disabling the link when the add-on is INCOMPLETE

Comment 2

[Justin Scott [:fligtar]]

(In reply to comment #1)
> This is just disabling the link when the add-on is INCOMPLETE

We changed our minds. In the dashboard, any incomplete add-ons should only have the option to finish the submission process or delete the add-on. We might also want to indicate the add-on will be deleted automatically after a few days if not finished.

chowse, do you mind?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/2336468

Comment 4

[krupa raj[:krupa]]

As per comment 2, an incomplete add-on should have links to complete/delete the add-on and nothing else.

But my incomplete add-on[255386] has links to other options like Payments etc in the dashboard

STR:
1. Load https://addons.allizom.org/z/en-US/developers/addons
2. Notice the options available for the incomplete add-on "firebug"

However, the name of the link is not linked anymore. 

Did we change our minds about comment 2 or am I missing something?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Fixed in commit https://github.com/jbalogh/zamboni/commit/a2b87d0

Comment 6

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/z/en-US/developers/addons?page=2

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot