Closed Bug 563588 Opened 10 years ago Closed 10 years ago

Control+leftArrow/rightArrow/home/end can no longer be used to move tabs on the tab bar

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.7a5

People

(Reporter: Jamie, Assigned: dao)

References

Details

(Keywords: access, regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100503 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100503 Minefield/3.7a5pre

In Firefox 3.6, while focused on the tab bar, it is possible to move tabs left and right by pressing control+leftArrow and control+rightArrow respectively. Similarly, it is possible to move the current tab to become the first tab using control+home and to become the last tab using control+end. This is no longer possible in Firefox 3.7pre.

Reproducible: Always

Steps to Reproduce:
1. Open two tabs containing  different pages.
2. Move focus to the tab bar.
3. Select the first tab.
4. Press control+rightArrow.
Actual: Nothing happens.
Expected: The tab should move to the right, making it the second tab.
5. Ensure that the second tab is selected.
6. Press control+leftArrow.
Actual: Nothing happens.
Expected: The tab should move to the left, making it the first tab.
7. Ensure that the first tab is selected.
8. Press control+end.
Actual: Nothing happens.
Expected: The tab should move to become the last tab.
9. Ensure that the second tab is selected.
10. Press control+home.
Actual: Nothing happens.
Expected: The tab should move to become the first tab.
Keywords: access, regression
Version: unspecified → Trunk
Regression range:

works:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100316 Minefield/3.7a4pre
http://hg.mozilla.org/mozilla-central/rev/050887c64183

broken:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100317 Minefield/3.7a4pre
http://hg.mozilla.org/mozilla-central/rev/16a974dd72e1

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=050887c64183&tochange=16a974dd72e1
Blocks: 347930
OS: Windows 7 → All
Hardware: x86 → All
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #444045 - Flags: review?(gavin.sharp)
Comment on attachment 444045 [details] [diff] [review]
patch

Kind of seems like this should be handled by the tab container...
Attachment #444045 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/9a140fd59304
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Why didn't this land with tests?  This seems very testable...
Flags: in-testsuite?
Verified fixed in: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100511 Minefield/3.7a5pre
Status: RESOLVED → VERIFIED
test: http://hg.mozilla.org/mozilla-central/rev/db80492d7583
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.