563600 - Valgrind: Invalid read [@ indic_ot_reorder] in libpango

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a5pre) Gecko/20100503 Minefield/3.7a5pre

On Ubuntu 10.04

Comment 1

[Jesse Ruderman]

I installed a pango debugging package, and valgrind magically gave me better symbols ;)

Comment 2

[Jesse Ruderman]

Attachment: valgrind output

Comment 3

[Behdad Esfahbod]

Jonathan, you understand the Indic code better.  Can you check it out please?

Comment 4

[Mats Palmgren (inactive)]

WFM, local Linux64 debug ASAN build.  Jesse, can you still reproduce this?

Comment 5

[Jonathan Kew [:jfkthame]]

As of bug 797398, we no longer use pango for Indic (or any other) shaping. So the testcase would now be testing our in-tree version of harfbuzz, rather than the system's installed version of pango.

Comment 6

[Mats Palmgren (inactive)]

OK, great.  So this is only a bug on mozilla18 and older then.

Comment 7

[Mats Palmgren (inactive)]

WFM, aurora (Fx18) and release (Fx16) Linux64 debug ASAN (local builds).

Comment 8

[Jonathan Kew [:jfkthame]]

It's almost certainly dependent on your system's version of pango (and/or installed fonts). I think it's really a pango bug (and likely fixed anyway in current pango), but we're rapidly losing interest as we've moved away from relying on system pango anyway.

Comment 9

[Behdad Esfahbod]

Even Pango removed all its Indic shapers.  So I (upstream Pango) don't care either.  If there's anyone interested, it's the RHEL / Debian types.