Closed Bug 56368 Opened 24 years ago Closed 24 years ago

pref-wallet.xul abuses <script>...</script>

Categories

(SeaMonkey :: Preferences, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: timeless, Assigned: bugs)

References

()

Details

Please move <script language="JavaScript"> <![CDATA[ function viewWallet() function viewWalletSites() ]]> </script> into a .js file.
(without having looked at the XUL file, a question) do these inline scripts adversely affect the readability of the file? This use is perfectly legal.
They prevent others from calling these functions. I have just filed a bunch of bugs. Most of them want the .js file so that the functions could be called from elsewhere.
over to autofill...
Component: Preferences → Autofill
QA Contact: sairuh → tpreston
Please post the numbers of those bugs here so I can see how/why you want to call these functions.
I'm not sure why people would need to justify wanting to call those functions: it's not like you could prevent them from just copying and pasting, so the net effect here would be, at worst, to prevent some programming-with-the-edit-menu. But my interest in this bug stops with that.
Assignee: shaver → morse
I have no desire to stop people from calling these routines. It's just that I didn't see any reason to double the number of preference files (one js file for every xul file) which is what I presume was ben's original motivation when he structured the files the way he did. Reassigning to ben since he's the one who did this structuring. If he wants to change it, it's alright with me.
Assignee: morse → ben
Component: Autofill → Preferences
See related bugs 56365, 56368, 56370, 56372, and 56374.
.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.