563682 - Latest Secret phrase does not update in password manager

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

When you change the secret phrase within weave prefs, it will not get immediately updated within password manager (Show passwords).   Instead, its the previous instance shown from the last time you updated the phrase.

If you then update your secret phrase again, you'll then see the previous phrase updated from the last round.  So in summary, the shown passwords seems to be one instance behind.

Repro:
1) install weave 1.3b3 and login
2) change secret phrase x1 (eg. "secretphrase1")
3) open pwdmgr > show passwords, and notice the secret phrase is not what you just changed.
4) change secret phrase x2 (eg. "secretphrase2")
5) open pwdmgr > show passwords, and notice the secret phrase is now "secretphrase1"
6) change secret phrase x3 (eg. "somethingNew!")
7) show passwords shows "secretphrase2")
8) etc...etc...

With changing account passwords, it seems to reflect the change immediately after opening/closing pwdmgr.

Expected:
- changing secret phrase for that instance should dynamically reflect the changes in pwdmgr

Actual:
- secret phrase seems to be one-off behind.


** Is this related to bug 563360?

Comment 1

[Mike Connor [:mconnor]]

changePassphrase, unlike changePassword, doesn't call persistLogin.  Why, I have no idea.

Comment 2

[Mike Connor [:mconnor]]

Attachment: v1

Comment 3

[Ed Lee :Mardak]

Comment on attachment 443401 [details] [diff] [review]
v1

Mmm.. I remember fixing this before.

Comment 4

[Ed Lee :Mardak]

Aha! http://hg.mozilla.org/labs/weave/rev/23d90c46b89c#l4.14

Comment 5

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/947ca50e3db2