563810 - With no fallback update specified in the snippets, Firefox hangs when trying to fetch it

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

While running the Mozmill tests for the 3.6.4build1 -> build3 update process we have noticed that Firefox tries to download a fallback update, even when none is specified in the update snippet.

I have created a screencast of the Mozmill test-run:
http://screencast.com/t/ZDk3Y2EzO

Steps:
1. Install Firefox and update the channel
2. Download the update
3. Force the update to be failed
4. Start Firefox again
5. Click 'Continue' in the software update dialog

After step 5 we end-up in an endless loop and when pressing hide and opening the software update dialog again, nothing happens. Closing Firefox afterward causes a hang and forces you to kill the browser.

Ben, can you please attach a copy of the update snippet which causes this problem? Thanks.

Comment 1

[Robert Strong (they/them - no direct email)]

I am fairly certain this is fixed on trunk as part of the app update rewrite in bug 530872. Can you check if this also happens on trunk?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

whimboo, you can use a nightly that's more than one build behind to check that.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: updates.xml which AUS was serving

Only a complete update defined.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can't run the software update tests with Mozmill for Minefield because we do not support builds on mozilla-1.9.3 yet. But running those manually with a version from May 1st it works fine. There is no 'Continue' button anymore and I get no hang.

So I would mark this bug as fixed on trunk. For 1.9.2 and 1.9.1 we should still continue to offer fallback updates for each security release.

Comment 5

[Robert Strong (they/them - no direct email)]

Fixed on 1.9.2 for Firefox 3.6.9 by bug 576939.