Closed Bug 563845 Opened 12 years ago Closed 12 years ago

skip jsval-to-jsid conversion when jsval is a jsid

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: luke, Assigned: luke)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch patchSplinter Review
This patch just tightens some assertions to simplify things for the fat-value patch.
Attachment #443531 - Flags: review?(igor)
Comment on attachment 443531 [details] [diff] [review]
patch

An ultimate solution would to fix the the signature of the resolve hook and setters/getters so they take the id, not a value. But for now the change is very rightful.
Attachment #443531 - Flags: review?(igor) → review+
(In reply to comment #1)
> (From update of attachment 443531 [details] [diff] [review])
> An ultimate solution would to fix the the signature of the resolve hook and
> setters/getters so they take the id, not a value.

Happening in bug 549143 :)
http://hg.mozilla.org/tracemonkey/rev/11a9245e9ed6
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/11a9245e9ed6
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.