Closed Bug 563884 Opened 10 years ago Closed 7 years ago

The link element should be display: none; in the UA style sheet

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: hsivonen, Assigned: swong15)

References

()

Details

(Keywords: helpwanted, html5, student-project)

Attachments

(4 files, 2 obsolete files)

Steps to reproduce:
 1) Load https://bugzilla.mozilla.org/attachment.cgi?id=392399

Actual results:
The link element participates in table layout.

Expected results:
Expected the link element not to participate in layout due to defaulting to display: none; per
http://www.whatwg.org/specs/web-apps/current-work/#the-css-user-agent-style-sheet-and-presentational-hints
Hi I'd love to work on this. Could you tell me where I should get started looking in the codebase to fix this?
Sebastian, see layout/style/html.css
Attached patch Attempt at patch v1. (obsolete) — Splinter Review
Added styling for the link tag. Change appears to fix the bug on my machine.
Sebastian, is that patch ready for review?  Do you want to add a reftest?  See https://developer.mozilla.org/en-US/docs/Creating_reftest-based_unit_tests
Attached file reftest.list
I believe the patch is ready for review. I have not generated a patch with hg yet and the current attached patch is just a file diff. 

Without the proposed patch I get the following output when running the reftest: 

0:01.36 REFTEST TEST-START | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/without_script.html | 0 / 1 (0%)
 0:01.47 REFTEST TEST-UNEXPECTED-FAIL | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/with_script.html | image comparison (==), max difference: 255, number of differing pixels: 324

With the proposed patch I get the following output when running the reftest: 

0:01.28 REFTEST TEST-START | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/without_script.html | 0 / 1 (0%)
 0:01.32 REFTEST TEST-PASS | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/with_script.html | image comparison (==)
OK.  The patch looks good, but you do want to have the reftest in the patch.  Adding it to layout/reftests/bugs/reftest.list and putting the files in layout/reftests/bugs is probably fine.
Attached patch 563884 patch. (obsolete) — Splinter Review
Added the changes you suggested. I'm still new so please let me know if theres anything I need to do
Attachment #751814 - Attachment is obsolete: true
Attachment #752381 - Flags: review?(bzbarsky)
Comment on attachment 752381 [details] [diff] [review]
563884 patch.

It looks like you forgot to hg add the actual test files?
Attached patch 563884 patchSplinter Review
Whoops. There you go!
Attachment #752381 - Attachment is obsolete: true
Attachment #752381 - Flags: review?(bzbarsky)
Attachment #752521 - Flags: review?(bzbarsky)
Comment on attachment 752521 [details] [diff] [review]
563884 patch

r=me if you put the new line in reftest.list in the right place in numerical order.

Thank you!
Attachment #752521 - Flags: review?(bzbarsky) → review+
Attachment #752521 - Flags: checkin?
Keywords: checkin-needed
Attachment #752521 - Flags: checkin?
https://hg.mozilla.org/mozilla-central/rev/74c44f375275
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.