Note: There are a few cases of duplicates in user autocompletion which are being worked on.

The link element should be display: none; in the UA style sheet

RESOLVED FIXED in mozilla24

Status

()

Core
Layout
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: hsivonen, Assigned: Sebastian Wong)

Tracking

({helpwanted, html5, student-project})

Trunk
mozilla24
helpwanted, html5, student-project
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments, 2 obsolete attachments)

Steps to reproduce:
 1) Load https://bugzilla.mozilla.org/attachment.cgi?id=392399

Actual results:
The link element participates in table layout.

Expected results:
Expected the link element not to participate in layout due to defaulting to display: none; per
http://www.whatwg.org/specs/web-apps/current-work/#the-css-user-agent-style-sheet-and-presentational-hints

Updated

7 years ago
Keywords: helpwanted, student-project
(Assignee)

Comment 1

4 years ago
Hi I'd love to work on this. Could you tell me where I should get started looking in the codebase to fix this?

Comment 2

4 years ago
Sebastian, see layout/style/html.css
(Assignee)

Comment 3

4 years ago
Created attachment 751814 [details] [diff] [review]
Attempt at patch v1.

Added styling for the link tag. Change appears to fix the bug on my machine.

Comment 4

4 years ago
Sebastian, is that patch ready for review?  Do you want to add a reftest?  See https://developer.mozilla.org/en-US/docs/Creating_reftest-based_unit_tests
(Assignee)

Comment 5

4 years ago
Created attachment 752356 [details]
reftest.list
(Assignee)

Comment 6

4 years ago
Created attachment 752357 [details]
html file with link script
(Assignee)

Comment 7

4 years ago
Created attachment 752358 [details]
html file without link script
(Assignee)

Comment 8

4 years ago
I believe the patch is ready for review. I have not generated a patch with hg yet and the current attached patch is just a file diff. 

Without the proposed patch I get the following output when running the reftest: 

0:01.36 REFTEST TEST-START | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/without_script.html | 0 / 1 (0%)
 0:01.47 REFTEST TEST-UNEXPECTED-FAIL | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/with_script.html | image comparison (==), max difference: 255, number of differing pixels: 324

With the proposed patch I get the following output when running the reftest: 

0:01.28 REFTEST TEST-START | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/without_script.html | 0 / 1 (0%)
 0:01.32 REFTEST TEST-PASS | file:///Users/sebastianwong/Documents/mozilla-central/bitmaptest/with_script.html | image comparison (==)

Comment 9

4 years ago
OK.  The patch looks good, but you do want to have the reftest in the patch.  Adding it to layout/reftests/bugs/reftest.list and putting the files in layout/reftests/bugs is probably fine.
(Assignee)

Comment 10

4 years ago
Created attachment 752381 [details] [diff] [review]
563884 patch.

Added the changes you suggested. I'm still new so please let me know if theres anything I need to do
Attachment #751814 - Attachment is obsolete: true
Attachment #752381 - Flags: review?(bzbarsky)

Comment 11

4 years ago
Comment on attachment 752381 [details] [diff] [review]
563884 patch.

It looks like you forgot to hg add the actual test files?
(Assignee)

Comment 12

4 years ago
Created attachment 752521 [details] [diff] [review]
563884 patch

Whoops. There you go!
Attachment #752381 - Attachment is obsolete: true
Attachment #752381 - Flags: review?(bzbarsky)
Attachment #752521 - Flags: review?(bzbarsky)

Comment 13

4 years ago
Comment on attachment 752521 [details] [diff] [review]
563884 patch

r=me if you put the new line in reftest.list in the right place in numerical order.

Thank you!
Attachment #752521 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

4 years ago
Attachment #752521 - Flags: checkin?
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Attachment #752521 - Flags: checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/74c44f375275
Assignee: nobody → swong15
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/74c44f375275
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.