563890 - Remove nsHTMLContentSink from the tree

Status: NEW

(Core :: DOM: HTML Parser, enhancement, P4)

Description

[Henri Sivonen (:hsivonen)]

nsHTMLContentSink should be removed as dead code once it is no longer used.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Remove the old sink and prefs for taking code paths that used it

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I like!

There's a test for the interface isindex elements implement with the old parser; it looks like you missed it.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to comment #2)
> There's a test for the interface isindex elements implement with the old
> parser; it looks like you missed it.

There's a whole bunch of tests that need editing. Filed bug 655701 about those.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Remove the old sink and prefs for taking code paths that used it, rebased

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 560571 [details] [diff] [review]
Remove the old sink and prefs for taking code paths that used it, rebased

Review of attachment 560571 [details] [diff] [review]:
-----------------------------------------------------------------

Woo!

Comment 6

[Radek 'sysKin' Czyz]

It's been six months since review - was this forgotten or it's waiting for something I can't see?

Comment 7

[Henri Sivonen (:hsivonen)]

(In reply to Radek 'sysKin' Czyz from comment #6)
> It's been six months since review - was this forgotten or it's waiting for
> something I can't see?

It's waiting for its dependencies. At this point, bug 543435 is the one left.