563989 - Reset Sync option 3, doesn't properly propagate to other clients.

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tracy Walker [:tracy]]

Filing as a follow up to bug 563443. as seen on 1.3b4

0) A and B are in sync.  
1) On B, disconnect weave, then remove a bunch of bookmarks from the toolbar.
2) Reset sync on Client A with option 3, Replace all other devices with your
local data. let sync complete.
3) Run sync on client B.

Tested results:
The bookmarks that were removed there are not restored by the sync.

Expected results:
The sync from client A should have restored the deleted bookmarks on client B.

Also,  further syncs of both machines A and B does not restore the deleted
bookmarks.  The clients remain out of sync.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

bug 526569: moved wipeRemote before client sync, so recipient list may be unknown
bug 534218: wipeRemote happens after remoteSetup, so syncID change to force data upload doesn't work
bug 556454: client engine doesn't have a pref to enable, so they weren't syncing

Comment 3

[Tony Chung [:tchung]]

good candidate for crossweave unit tests.

Comment 4

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/7a66c793d465
Always sync client data by making sure it's always enabled and only update local cilent with remote commands. Make sure to sync clients to get a list of clients that need to receive commands. Also, make sure to upload data after wiping remote now that remoteSetup happens before wipeRemote.

Comment 5

[Tracy Walker [:tracy]]

verified with 1.3b5

Comment 6

[Ayan Shah[:ashah]]

Investigating this bug for being potential crossweave automation test case
candidate.

Comment 7

[Jonathan Griffin (:jgriffin)]

Added crossweave test for this as http://hg.mozilla.org/automation/crossweave/rev/0ffcc5f9307f