Closed Bug 564017 Opened 15 years ago Closed 15 years ago

Clear out the notification thread during Abort

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED
flash10.1

People

(Reporter: bgetlin, Assigned: bgetlin)

Details

(Whiteboard: Has patch)

Attachments

(1 file)

When Abort() is triggered, make sure to clear out the flag indicating we're already sending a memory status notification. This will guarantee kMemAbort signal is sent if we hit abort during another status change. A number of bad symptoms may periodically occur before this fix, including hangs, crashes, and missing OOM UI.
Attached patch gcheap patchSplinter Review
Attachment #443702 - Flags: superreview?(lhansen)
Attachment #443702 - Flags: review?(treilly)
p4 change : 667852
Attachment #443702 - Flags: review?(treilly) → review+
Attachment #443702 - Flags: superreview?(lhansen) → superreview+
Assignee: nobody → bgetlin
Status: NEW → ASSIGNED
Component: Virtual Machine → Garbage Collection (mmGC)
Priority: -- → P2
QA Contact: vm → gc
Whiteboard: Has patch
Target Milestone: --- → flash10.1
Flags: flashplayer-qrb+
Needs to land in TR and TR-Argo. Note the CL's here when landing.
tamarin-redux-argo: changeset: 4030:6c7130c61ed8
tamarin-redux - changeset - 4659:6c7130c61ed8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
QA Contact: gc → dschaffe
reran oom testsuite on Play_1_r53_57. Let me know if there is a more specific testcase we can use for verification. marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: