Closed
Bug 564070
Opened 14 years ago
Closed 14 years ago
_getvalueforurl needlessly clones an owned string
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
After _getvalueforurl retrieves the cookie string from the cookie service, it then clones it. In fact the original string was a better match for the return value, as it was allocated with NS_Alloc instead of PR_Malloc.
|
Assignee | |
Comment 1•14 years ago
|
||
The first change is just a pedantic correctness fix.
|
||
Updated•14 years ago
|
Attachment #443761 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed changeset c5976fc3311c to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•