_getvalueforurl needlessly clones an owned string

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
After _getvalueforurl retrieves the cookie string from the cookie service, it then clones it. In fact the original string was a better match for the return value, as it was allocated with NS_Alloc instead of PR_Malloc.
(Assignee)

Comment 1

8 years ago
Created attachment 443761 [details] [diff] [review]
Proposed patch

The first change is just a pedantic correctness fix.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #443761 - Flags: review?(jst)

Updated

8 years ago
Attachment #443761 - Flags: review?(jst) → review+
(Assignee)

Comment 2

8 years ago
Pushed changeset c5976fc3311c to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.