564071 - reftest-print triggers "ASSERTION: nsPrintSettingsX::ReadPageFormatFromPrefs() failed: 'NS_SUCCEEDED(rv)" on mac tinderboxen

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Daniel Holbert [:dholbert]]

Our mac reftest runs apparently hit this assertion 101 times -- once during every "reftest-print" testcase, it looks like.
{
###!!! ASSERTION: nsPrintSettingsX::ReadPageFormatFromPrefs() failed: 'NS_SUCCEEDED(rv)', file /builds/slave/mozilla-central-macosx-debug/build/widget/src/cocoa/nsPrintOptionsX.mm, line 64
}

This happens on both 10.5 and 10.6, as shown by the logs below (one of each).

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273083630.1273086256.24827.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test reftest on 2010/05/05 11:20:30
s: talos-r3-leopard-023

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273087482.1273089690.8100.gz
Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/05 12:24:42
s: talos-r3-snow-004

Comment 1

[Daniel Holbert [:dholbert]]

see also bug 553154 comment 14, which mentions hitting the same assertion when simply trying to print.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> see also bug 553154 comment 14, which mentions hitting the same assertion when
> simply trying to print.

To be specific, I just did Cmd-P there (and then cancelled without printing, but AFAICT that assertion appeared as the native print UI was appearing, not after cancelling it).

Comment 3

[(no longer active)]

This happens because the print.macosx.pagesetup-2 pref is not set by default, so this call fails:

<http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsPrintSettingsX.mm#149>

Which causes an assertion in:

<http://mxr.mozilla.org/mozilla-central/source/widget/src/cocoa/nsPrintOptionsX.mm#64>

It seems to me that this assertion needs to be removed, because it does not assert something which should generally happen.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[Josh Aas]

Comment on attachment 445637 [details] [diff] [review]
Patch (v1)

I'm fine with this if mstange is fine with it.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/763e567872bb