564075 - Url bar gets displaced, with open sidebar, focusing url bar and then dismissing awesome bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: screenshot

To reproduce:
- Pan left to open the sidebar
- Tap the url bar, the awesome bar popup opens
- Dismiss it by tapping on the top right button

Result:
The url bar is displaced, it doesn't extend anymore over the sidebar as it usually does. See screenshot of what I mean.

I can reproduce this on a n900 Fennec from 2010-05-05 1.9.2.5pre.
I couldn't reproduce it on windows, for some reason, though.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This is a regression caused by bug 537717. I'm working on it.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch should be more robust and prevent that.

It also include a fix for that prevent opening the urlbar for just a onmouseup (introduce in bug 557619) which is annoying on device when the sidebars are open and we pan fast by releasing the finger on the urlbar!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 443866 [details] [diff] [review]
Patch

Patch looks good and should be more robust than the current code.

I wish there was a way to test this better. We have had too much breakage from changes like this.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/a2e656e33376

pushed m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/54e433fbd370

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100507 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100507 Namoroka/3.7a5pre Fennec/2.0a1pre