"ASSERTION: Ancestors of nodes with frames to be constructed lazily should not have NEEDS_FRAME bit set" and more with framesets

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Jesse Ruderman, Assigned: tnikkel)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
x86_64
Linux
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 444036 [details]
testcase

###!!! ASSERTION: Ancestors of nodes with frames to be constructed lazily should not have NEEDS_FRAME bit set: '!content->HasFlag(NODE_NEEDS_FRAME) || content->GetPrimaryFrame()->GetContent() != content', file /home/jruderman/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 6247

###!!! ASSERTION: NEEDS_FRAME set on a node that already has a frame?: '!child->GetPrimaryFrame() || child->GetPrimaryFrame()->GetContent() != child', file /home/jruderman/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 6332

###!!! ASSERTION: shouldn't get here with a content node that has needs frame bit set: '!aContent->HasFlag(NODE_NEEDS_FRAME)', file /home/jruderman/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 6303
(Assignee)

Comment 1

8 years ago
Created attachment 444237 [details] [diff] [review]
patch

We insert a frameset, it gets constructed lazily but the lazy bits don't get removed when nsHTMLFramesetFrame::Init creates the frame.

Are there any other places that might need similar treatment?
Assignee: nobody → tnikkel
Attachment #444237 - Flags: review?(bzbarsky)
Comment on attachment 444237 [details] [diff] [review]
patch

Hmm.  Not outside of XUL, I don't think.  Most other things play nice.

Certainly framesets were the only place I found that needed SetPrimaryFrame hackery.
Attachment #444237 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

8 years ago
Landed
http://hg.mozilla.org/mozilla-central/rev/b166415b8c3f

but backed out because something in the push was causing orange
http://hg.mozilla.org/mozilla-central/rev/01befa5163ee
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/7313058e136a
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.