sec_pkcs12_decoder_safe_bag_update is forward declared after its implementation

RESOLVED FIXED in 3.12.7

Status

P4
trivial
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

trunk
3.12.7

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Defined as a function in:
    * security/nss/lib/pkcs12/p12d.c
          o line 316 -- sec_pkcs12_decoder_safe_bag_update(void *arg, const char *data, 

Defined as a function prototype in:
    * security/nss/lib/pkcs12/p12d.c
          o line 367 -- sec_pkcs12_decoder_safe_bag_update(void *arg, const char *data,
Taking, since I'm fixing a slew of memory leaks in that same file.
Assignee: nobody → nelson
(Assignee)

Comment 2

9 years ago
Created attachment 444043 [details] [diff] [review]
patch
Assignee: nelson → timeless
Status: NEW → ASSIGNED
Attachment #444043 - Flags: review?(nelson)
Comment on attachment 444043 [details] [diff] [review]
patch

Yeah, I'm inclined to move those other forward declarations higher up in the source file, too.
Attachment #444043 - Flags: review?(nelson) → review+
Checking in p12d.c; new revision: 1.48; previous revision: 1.47
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Priority: -- → P4
Target Milestone: --- → 3.12.7
You need to log in before you can comment on or make changes to this bug.