Closed Bug 564537 Opened 15 years ago Closed 14 years ago

Refactor classes for mozmill, jsbridge, and mozrunner to be independent from their CLI classes

Categories

(Testing Graveyard :: Mozmill, defect)

Product:
Testing Graveyard
Component:
Mozmill
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [mozmill-1.5.1+][CLI])

Right now we have a strong correlation between the CLI classes and the mozmill, jsbridge, and mozrunner classes. A lot of stuff which is part of the CLI classes should be moved over to the base classes. I really would like to see properties which are used to set any data in the base classes. I work on a wrapper class for that on bug 563523 which we could apply to the orig classes. See: http://github.com/whimboo/mozmill/commit/0baa229cb25f8cbda39326a4df6186f81aaaec5d#diff-2
Would be fantastic to have it in the next release.
Whiteboard: [mozmill-1.4.2?]
Whiteboard: [mozmill-1.4.2?] → [mozmill-1.4.2-]
Whiteboard: [mozmill-1.4.2-] → [mozmill-2.0?][CLI]
Blocks: 566314
Is what in master now close to what is desired?
This module got a complete refactoring so I would tend to say so. If something is still missing or not working I will file another bug. Lets close this bug.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Oh, and this is now even part of Mozmill 1.5.1.
Whiteboard: [mozmill-2.0?][CLI] → [mozmill-1.5.1+][CLI]
I would argue that either in 1.5.1 and master isn't a very good abstraction of API vs CLI, but if you want to close and ticket subsequent issues separately, that's fine too.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.