56459 - Open attachment, download progress never goes away

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Phil Peterson]

Using 10/12 RTM branch build on NT

1. Receive email with MS Word attachment
2 [details] [diff] [review]. Open attachment -- click Open in both open/save dialogs :-(
3. Download progress dialog comes up
4. MS Word comes up with attachment loaded

Expected: download progress dialog to go away 
Actulal: dialog stays up until you click the Cancel button

Comment 1

[Scott MacGregor]

*sigh* I was hoping someone wouldn't notice this. I've been sticking my head in
the sand while I tried to figure it out in the background. There's a problem
with the JS object xpconnect is giving us for the progress window when it comes
from mail.

I'll keep poking at it. You should only see it when downloading large attachments.

Comment 2

[Scott MacGregor]

Attachment: proposed fix

Comment 3

[Scott MacGregor]

Wow, this turned out to be way easy. I spent all this time in the guts of xp
connect thinking it was a JS context wrapper problem just to discover that one
of my objects didn't implement QueryInterface for one of the methods it supports
(nsIRequest).

Phil, do you think we have a chance of getting this through PDT today? (i.e. is
it worth me nominating for rtm and getting it on the radar)? I know it's getting
awfully late in the cycle.

cc'ing alecf and bienvenu for sr, and r.

The fix is super trivial, we have a nsIChannel interface which itself inherits
from another interface nsIRequest. I was calling a method on a JS object that
implements an interface with a method that takes a nsIRequest. I was passing an
imap channel object into this method as the nsIRequest object. Unfortunately I
didn't have nsIRequest explcitly listed in my QueryInterface method. So
xpconnect was silently failing to actually execute any methods where I needed to
pass in a nsIRequest.

Comment 4

[Phil Peterson]

> You should only see it when downloading large attachments.

I saw it when downloading a two page .DOC file which was 40-50k.

> do you think we have a chance of getting this through PDT today?

Not sure, but I'm happy to nominate it for discussion

Comment 5

[scottputterman]

adding rtm need info.

Comment 6

[Scott MacGregor]

sr=alecf
still waiting for bienvenu for the r=

Comment 7

[jefft]

Looks good to me. r=jefft

Comment 8

[Jim Roskind]

Rtm double plus.  This bug has bothered me a lot... so I'm strongly betting on
the reviews here... cause this is very borderline in risk/reward... Please land
this asap on both branch and trunk.

Comment 9

[David :Bienvenu]

sorry scott, DSL was down from noon Friday until now. Looks fine.

Comment 10

[Scott MacGregor]

I checked this in Friday night on both the tip and the branch. It works for imap
now.

Unfortunately the same one line change is needed for local & news: Adding
nsIRequest to the QueryInterface method for nsmsgProtocol.

I'll file a new bug for that issue. We may not want to take that change though
as thescenario is much less likely to happen. Especially for local because the
file copy operation is always finished by the time we bring up the UI asking the
user what they want to do with the content. So no progress dialog is invoked. 

Comment 11

[Jason Kersey]

This is fixed in 2000101608mn6 on winNt/2k.  vtrunking...

Comment 12

[pmock]

Verified as fixed on win32 branch build:
 -win32 commercial seamonkey build 2000-101710-mn6 installed on P500 Win98
 -MS Word launchs the document and the progress dialog closes itself.

Verified as fixed on macos branch build:
 -macos commercial seamonkey build 2000-101708-mn6 installed on G3/400 OS 9.04
 -MS Word did not open the document.  It saved the document but closed the 
progress dialog.

Verified as fixed on linux branch build:
 -linux commercial seamonkey build 2000-101712-mn6 installed on P200 RedHat 6.2
 -I did not have a program to open msword document but it did close the progress 
dialog.

Comment 13

[pmock]

Verified on win32 branch build using 
 win32 commercial seamonkey build 2000-101710-mn6 installed on P500 Win98

Need to check mac and linux next.

Comment 14

[fenella]

Assign it to myself.

Comment 15

[fenella]

Verifying it using 
Mac and Win32 (2001-02-12-08 mtrunk)