Closed Bug 564692 Opened 10 years ago Closed 10 years ago

Sync suite/feeds/ with mozilla-central

Categories

(SeaMonkey :: Feed Discovery and Preview, defect)

All
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(1 file, 1 obsolete file)

Port over some recent patches from the Firefox RSS feeds component.

Bug 364677 - No preview for sniffed feeds that don't have a channel/link or channel/id
Bug 487511 - nsINavHistoryObserver has no "onBeforeDeleteURI" callback
Bug 524270 - Make the second getChildList parameter optional
Bug 527433 - nsIWebContentConverterRegistrar::getContentHandlers count out param should be optional

* Backout part of Bug 480205 - Implement a wrapper for exposing chrome objects to content (aka COWs)
Part of this bug was backed out of Firefox. The bug is marked as sg: so I can't access it. I've based my patch on the relevant mercurial changeset instead.

I've included the test for Bug 364677 and all the rss feed mochitest-plain tests in suite work.
Attached patch Patch v1.0 with mochitest (obsolete) — Splinter Review
Actually attach the patch. I don't suppose Standard8 is doing suite reviews any time soon?
Attachment #444314 - Flags: review?(neil)
Comment on attachment 444314 [details] [diff] [review]
Patch v1.0 with mochitest

>   init: function init(aWindow) {
>-    // Explicitly wrap |window| in an XPCNativeWrapper to make sure
>-    // it's a real native object! This will throw an exception if we
>-    // get a non-native object.
>-    var window = new XPCNativeWrapper(aWindow);
Asking mrbkap why he removed this in the Firefox version.
Attachment #444314 - Flags: feedback?(mrbkap)
Comment on attachment 444314 [details] [diff] [review]
Patch v1.0 with mochitest

It shouldn't be necessarily needed anymore. On the other hand, I realized that it might not have been a great idea to take it out, since it technically increases attack surface. Either way is fine (and safe) though.
Attachment #444314 - Flags: feedback?(mrbkap) → feedback+
Comment on attachment 444314 [details] [diff] [review]
Patch v1.0 with mochitest

r=me with the XPCNativeWrapper guards restored.
Attachment #444314 - Flags: review?(neil) → review+
Carrying forward r=Neil

>  Blake Kaplan (:mrbkap)      2010-05-10 13:59:56 PDT

> (From update of attachment 444314 [details] [diff] [review])
> It shouldn't be necessarily needed anymore. On the other hand, I realized that
> it might not have been a great idea to take it out, since it technically
> increases attack surface. Either way is fine (and safe) though.

> neil@parkwaycc.co.uk 2010-05-10 16:16:10 PDT

> (From update of attachment 444314 [details] [diff] [review])
> r=me with the XPCNativeWrapper guards restored.

Fixed.
Attachment #444314 - Attachment is obsolete: true
Attachment #444624 - Flags: review+
Keywords: checkin-needed
Checked-in to comm-central
http://hg.mozilla.org/comm-central/rev/7f41e0b5db6b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.