Closed Bug 564702 Opened 14 years ago Closed 14 years ago

Fastback navigation sends bogus state change notifications to refresh listeners

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Proposed patch
674 bytes, patch
Biesinger
: review+
Details | Diff | Splinter Review 
Unlike the other web progress notifications, the state change notification is masked down to the state type, which is one of REQUEST, DOCUMENT, NETWORK and WINDOW. Unfortunately the way bug 292971 added the STATE_RESTORING bit to the state flags meant that it too was masked by a web progress listener bit. This
bit was fortuitously unused until bug 83265 used it for its refresh attempted notification. This means that although a listener may only be interested in a refresh it will in fact receive state changes for fastback navigation. In our case the JavaScript object in question has no method named onStateChange thus resulting in an XPConnect exception.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #444323 -
        Flags: review?(cbiesinger)

        Attachment #444323 -
        Flags: review?(cbiesinger) → review+

    
    

    
  
Pushed changeset aa20e4f73d81 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: