Closed Bug 564763 Opened 14 years ago Closed 14 years ago

ReservedSlotIndexOK and js_GetReservedSlot-limit are unused in nondebug builds

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

patch
1016 bytes, patch
timeless
: review+
Details | Diff | Splinter Review 
mozilla-central/js/src/jsobj.cpp:
 In function ‘bool js_GetReservedSlot(JSContext*, JSObject*, uint32, jsval*)’:
6359: warning: unused variable ‘limit’
 At global scope:
6334: warning: ‘bool ReservedSlotIndexOK(JSContext*, JSObject*, JSClass*, uint32, uint32)’ defined but not used
Attached patch patch — — Splinter Review 
Assignee: general → timeless
Status: NEW → ASSIGNED

        Attachment #444374 -
        Flags: review?(jorendorff)

        Attachment #444374 -
        Flags: review?(jorendorff) → review+

    
    

    
  
Timeless asked me to push a bunch of his patches to try a little while ago.  This one set Windows and Linux on fire.  It looks like these functions are used in nondebug builds on those platforms.

    
  

        Attachment #444374 -
        Flags: review+ → review-

    
    

    
  
oops, i was missing a dependency!
Depends on: 560557

    
  

        Attachment #444374 -
        Flags: review- → review+

    
  
Depends on: 568007

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/f39647a60911
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: