Closed
Bug 564771
Opened 16 years ago
Closed 16 years ago
FixedMalloc hygiene
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)
Tamarin Graveyard
Garbage Collection (mmGC)
Tracking
(Not tracked)
RESOLVED
FIXED
Q3 11 - Serrano
People
(Reporter: lhansen, Assigned: lhansen)
Details
(Whiteboard: has-patch)
Attachments
(1 file)
|
23.34 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
Hygiene issues: documentation, comments, #ifdefs, braces, indentation, information hiding.
FixedMalloc only; FixedAlloc will be handled elsewhere.
Attachment #444377 -
Flags: review?(treilly)
|
Assignee | |
Updated•16 years ago
|
Whiteboard: has-patch
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 444377 [details] [diff] [review]
Patch
This comment is no longer valid since we don't use pointers for the sub allocators anymore:
// Create all the allocators up front (not lazy) so that we don't
+ // have to check the pointers for NULL on every allocation.
Otherwise looks good
Attachment #444377 -
Flags: review?(treilly) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Nuked the comment.
tamarin-redux changeset: 4677:7587bf6b0214
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Flags: flashplayer-bug-
You need to log in
before you can comment on or make changes to this bug.
Description
•