Closed Bug 564861 Opened 12 years ago Closed 12 years ago

[OOPP] NPN_IntFromIdentifier returns INT_MIN always?

Categories

(Core :: Plug-ins, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking1.9.2 --- .4+
status1.9.2 --- .4-fixed

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(2 files)

From Ben Pryor @ Microsoft:

> We've found an issue with the latest Firefox builds and Silverlight. The 
> issue only repros when OOPP is enabled for the Silverlight plugin.
> 
> The issue concerns array-style access to a scriptable object (a 
> Silverlight object exposed to Javascript through Firefox's NPRuntime). 
> In Javascript, if I use array-style syntax against such an object, i.e.:
> 
> myobject[0]
> 
> then the following occurs:
> 
> - the browser calls our object's NPGetPropertyFunctionPtr
> 
> - we call NPN_IdentifierIsString on the NPIdentifier, and it returns false
> 
> - we call NPN_IntFromIdentifier on the NPIdentifier, and it returns 
> -2147483648 (i.e. INT_MIN for a 32-bit signed int)
> 
> NPN_IntFromIdentifier seems to return the same value regardless of the 
> Javascript syntax, i.e. myobject[0], myobject[1], etc. all give the same 
> behavior.
> 
> If OOPP is disabled for the Silverlight plugin, then 
> NPN_IntFromIdentifier returns 0, 1, etc. as expected.
blocking1.9.2: ? → .4+
Attached patch TestSplinter Review
Attachment #444463 - Flags: review?(bent.mozilla) → review+
Comment on attachment 444463 [details] [diff] [review]
Fix conditional and stop using -1 sentinel incorrectly, rev. 1

a=LegNeato for 1.9.2.4
Attachment #444463 - Flags: approval1.9.2.4+
Can we get a trybuild we can point MS at to see if this completely fixes the issue?
http://hg.mozilla.org/mozilla-central/rev/44347d8a48bc
http://hg.mozilla.org/mozilla-central/rev/4980a5f7467f

(in today's m-c nightly)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Duplicate of this bug: 559760
Mochitest passes on 1.9.2 post-checkin. Is this enough to verify this issue since there is no manual STR for the bug?
You should verify the dupped bug 559760 also, but the bug is fairly straightforward and the test covers it.
You need to log in before you can comment on or make changes to this bug.