564864 - Data mismatch warning when syncing on server

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Tony Chung [:tchung]]

on weave 1.3b5 and pointing to staging, i'm getting warnings during syncing from local to server (option 3 in setup client)

Repro:
1) install weave 1.3b5, enable tab tracing logging
2) setup account and point to stagings: https://stage-auth.services.mozilla.com
3) sync client using option 3; local data to server
4) verify activity log has a handful of data mismatch warnings:

2010-05-10 12:13:18     Engine.Tabs          WARN    Error processing record: Server attack?! SHA256 HMAC mismatch: c205d0f69b7bd71d3f16521650dcd36f6add53667b40b30274c0b1af4e3eb523 No traceback available

Full log: http://pastebin.mozilla.org/722881

Expected:
- no data mismatch warnings when syncing

Comment 1

[Ed Lee :Mardak]

The client is sending a delete for tabs but is getting records back. Is it possible that memcache is returning those records?

Comment 2

[Toby Elliott [:telliott]]

Found it. We weren't updating the set if tabs was empty. Will check in the fix and talk to zandr about a push

Comment 3

[Zandr Milewski [:zandr]]

Pushed to stage.

Comment 4

[Ed Lee :Mardak]

I'm assuming it's this change. ?

http://hg.mozilla.org/labs/weaveserver-sync/rev/773a11fc861c

Comment 5

[Toby Elliott [:telliott]]

Sorry, forgot to mark that. Yes

Comment 6

[Tony Chung [:tchung]]

I'm seeing this against Prod server now: https://phx-auth.services.mozilla.com/

Using option 3 like comment 0.
Here's my pastebin.  http://pastebin.mozilla.org/723146

Comment 7

[Zandr Milewski [:zandr]]

(In reply to comment #6)
> I'm seeing this against Prod server now: https://phx-auth.services.mozilla.com/

Pushed 1.3rc5 to the webheads to fix this.

Comment 8

[Tony Chung [:tchung]]

Seems fixed on phx production now