The default bug view has changed. See this FAQ.

Down scroll arrow hidden, draws behind resize widget when neither Status Bar nor horizontal scrollbar are displayed

RESOLVED FIXED in mozilla1.9.1a2

Status

()

Core
Widget: Cocoa
P3
normal
RESOLVED FIXED
17 years ago
3 years ago

People

(Reporter: Kathleen Brade, Assigned: mstange)

Tracking

(Depends on: 1 bug, {pp})

Trunk
mozilla1.9.1a2
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: relnote-user, URL)

Attachments

(9 attachments, 6 obsolete attachments)

8.49 KB, image/png
Details
778 bytes, image/png
Details
4.20 KB, image/gif
Details
37.61 KB, image/jpeg
Details
375 bytes, text/html
Details
5.27 KB, image/png
Details
443 bytes, text/html
Details
10.10 KB, patch
Details | Diff | Splinter Review
54.08 KB, image/jpeg
Details
(Reporter)

Description

17 years ago
In a navigator window, go to the above url:  (bugzilla's query page)
Choose View Source from the menu (or command-u)
Notice that the bottom arrow of the scrollbar seems to be under the growbox.
Also notice that I don't have a horizontal scrollbar even though the text scrolls 
off the right edge of the window.

On Linux, I see both scrollbars and the resize corner is not obscureed (not that 
it would be on Linux tho).
pushing to don's team. there are so many problems with this window, I can't even
count them.
Assignee: asa → don
Component: Browser-General → XP Apps: GUI Features

Comment 2

17 years ago
Pink files this ages ago. It's a generic chrome problem; they need to take the 
Mac's resize widget into account.
(Reporter)

Comment 3

17 years ago
the right thing seems to happen on Linux... there is space for one on Linux 
(though linux doesn't need it).

Maybe the real problem is that the horizontal scrollbar is missing?
Keywords: pp

Comment 4

17 years ago
workaround, use Edit Page HTML Source view ;)  We should just replace view
source with that.  

Comment 5

17 years ago
setting default qa (se), who hopefully has access to a mac to better service
this bug
QA Contact: doronr → sairuh
pink/simon, either of you remember the bug# for this problem pink filed? thx!
Keywords: relnoteRTM

Comment 7

17 years ago
Hrm, no.

What's odd here is that sometimes the bottom scrollbar shows up, and sometimes 
not. It seems to depend on what the source is like (though, in both cases, the 
source can be wide enough that there ought to be a scrollbar).

Updated

17 years ago
Whiteboard: relnote-user
Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy
Assignee: don → vishy
nav triage team: not a beta stopper. 
Keywords: nsbeta1-

Comment 10

16 years ago
If I understood the description correctly, this doesn't happen for me anymore.
Can anyone else still reproduce this?

Comment 11

16 years ago
Marking nsbeta1- bugs as future to get off the radar.
Target Milestone: --- → Future

Comment 12

16 years ago
I think that this has been fixed for a while. I can certainly see the bottom
vertical scroll arrow and the entire horizontal scrollbar in the 'Source' window
listing for the Bugzilla Query page URL.

I'm using the 2001-07-12-08 build on Mac OS 9.1 and the 2001-07-24-08 build on
Mac OS 8.6.
i think this is only a problem when there is no horizontal scrollbar, so the 
vertical scrollbar goes all the way to the bottom of the window.

Comment 14

16 years ago
Oops! You're right, Mike. It's the same when there's only a horizontal scrollbar
and no vertical one. View the source of http://www.eastern.co.uk for an example.

Comment 15

16 years ago
--> view source owner
Assignee: vishy → doronr
mass moving open bugs pertaining to view source to pmac@netscape.com as qa contact.

to find all bugspam pertaining to this, set your search string to
"ItsSharkeysNight".
QA Contact: sairuh → pmac

Comment 17

15 years ago
*** Bug 108503 has been marked as a duplicate of this bug. ***

Comment 18

15 years ago
change summary to reflect generic status. The horizontal scrollbar
thing needs to go in a different bug.

Feel free to flame like hell if I fucked up...
Summary: view source window lacks bottom arrow for vert scrolling & horz scrollbar → resize widget (growbox) hides bottom arrow in scrollbar

Comment 19

15 years ago
i presume this isn't a themes issue...
Assignee: doronr → blaker
Keywords: helpwanted
QA Contact: pmac → sairuh
Target Milestone: Future → ---

Comment 20

15 years ago
*** Bug 124527 has been marked as a duplicate of this bug. ***

Comment 21

15 years ago
Created attachment 72770 [details]
Screenshot (PNG) of hidden bottom arrow on Mac OS X

This illustrates the bug still occuring on Mac OS X (build 2002030508), in the
Bookmark Manager window, in comparison to a browser window which does not
exhibit the problem.

Comment 22

15 years ago
*** Bug 61234 has been marked as a duplicate of this bug. ***

Comment 23

15 years ago
*** Bug 88817 has been marked as a duplicate of this bug. ***

Comment 24

15 years ago
*** Bug 89301 has been marked as a duplicate of this bug. ***

Comment 25

15 years ago
*** Bug 140364 has been marked as a duplicate of this bug. ***

Comment 26

15 years ago
*** Bug 153565 has been marked as a duplicate of this bug. ***

Comment 27

15 years ago
*** Bug 157306 has been marked as a duplicate of this bug. ***

Updated

15 years ago
Summary: resize widget (growbox) hides bottom arrow in scrollbar → Down scroll arrow draws behind resize widget when neither Status Bar and horizontal scrollbar are displayed

Updated

15 years ago
Summary: Down scroll arrow draws behind resize widget when neither Status Bar and horizontal scrollbar are displayed → Down scroll arrow draws behind resize widget when neither Status Bar nor horizontal scrollbar are displayed

Comment 28

15 years ago
*** Bug 138149 has been marked as a duplicate of this bug. ***

Comment 29

15 years ago
*** Bug 142320 has been marked as a duplicate of this bug. ***

Comment 30

15 years ago
*** Bug 98125 has been marked as a duplicate of this bug. ***

Comment 31

15 years ago
*** Bug 161738 has been marked as a duplicate of this bug. ***

Comment 32

15 years ago
*** Bug 162898 has been marked as a duplicate of this bug. ***

Comment 33

15 years ago
*** Bug 147295 has been marked as a duplicate of this bug. ***

Comment 34

15 years ago
Created attachment 95684 [details]
no righthand horizontal scroll arrow in Source window under Mac OS 9.2.2

Comment 35

15 years ago
I have confirmed this bug using both the Modern theme and the 'Little Mozilla
1.1' theme. See attachment id=95684 which shows the lack of this arrow.

Mac OS 9.2.2 English-North American
Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.1) Gecko/20020814
Build ID 2002081422

Why no patch after nearly 5 months? Isn't the idea to be *better* than MS IE ?

Comment 36

15 years ago
I downloaded and installed Build ID: 2002082808 only to find that the scroll
arrows no longer initiate scrolling in either direction.  They do highlight when
selected; but, no scrolling takes place.  The ability to intiate scrolling via
moving the cursor in or around the highlighted control is also no longer
present.  What changed?

Comment 37

15 years ago
Frank, that's bug 161365, not this one.

Comment 38

15 years ago
*** Bug 169082 has been marked as a duplicate of this bug. ***

Comment 39

15 years ago
*** Bug 170223 has been marked as a duplicate of this bug. ***

Comment 40

15 years ago
*** Bug 111004 has been marked as a duplicate of this bug. ***

Comment 41

15 years ago
Created attachment 100183 [details]
Scrollbar arrow missing in help window, compared to standard window

This bug is still alive, after two years!?

Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1) Gecko/20020826

Steps to Reproduce:
1. Open the Help window
2. Select a topic with a lot of content (Browsing the web)
3. Look at the lower right corner of the window, there is no down arrow !

Comment 42

15 years ago
*** Bug 173991 has been marked as a duplicate of this bug. ***
There are two test case for "View Source" in bug Bug 173991 

Comment 13 of this one is right

Comment 44

15 years ago
*** Bug 174917 has been marked as a duplicate of this bug. ***

Comment 45

15 years ago
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2b) 
Gecko/20021016 MultiZilla/v1.1.21

This bug is also seen in some cases where a new browser window is opened through
a javascript. Go to : 
http://www.wired.com/news/mac/0,2125,55395-2,00.html
and click on one of the thumbnails.

Also, if you go to Menu: View -> Show/Hide -> Status Bar and toggle this off for
a normal browser window (like the one you are watching now), the bottom arrow
disappears below the window growbox. Thus, this bug seems to be dependent on
whether a status bar is displayed or not. 
This bug keeps annoying me, and it is REALLY annoying.

When clicking the 'toggle toolbar' button in the right corner of the OS X title
bar, wich i do often to make more room available, the down-arrow of the vertical
scrollbar disappears behind the resize-thing...

I have a (very simple) workaround in mind, wich would make life much easier for
me: do not make the status bar disappear when clicking on the 'toggle toolbar'
button. I've already disallowed scripts to remove the status bar, so i the bug
really only bugs me when using the toggle toolbar button.

Personally i think this would be ideal for OS X users. (At least as an option...
I don't mind losing 18 pixels of space, now i'm not using the toggle function
i'm 'losing' far more...)
Maybe I'm stupid, and handling against all bugzilla rules, but dear developers,
will you please NOT FORGET this bug!

Comment 48

15 years ago
*** Bug 181876 has been marked as a duplicate of this bug. ***

Comment 49

15 years ago
*** Bug 182668 has been marked as a duplicate of this bug. ***

Comment 50

15 years ago
*** Bug 183719 has been marked as a duplicate of this bug. ***

Comment 51

15 years ago
Please, refrain from adding evangelical comments. Contribute code, or just vote
for it.

Comment 52

15 years ago
Yes, it is highly annoying and bothersome to deal with "evangelical" comments --
strong words actually have effects, you know, and sometimes they actually
motivate people. We must have None Of That! And for dealing with a bug that has
been opened for two years, why nothing is more appropriate than steadfast
silence! After all, it's a commonly-known truth in the open source world that
everyone can code just as well as everyone else! Why don't I just submit the fix
myself instead of being a bug senteniel and beta-testing the product? I should
immediately forgo all of those activities (and my own Moz evangelism, too,
because evangelism is a big no-no apparently) and just vote or code. But on the
serious side of the fence, it is absolutely preposterous to expect bugs with
long histories to NOT have their occasional posts by frustrated users. 

Thanks for the help, Tarage,

Well, I WOULD certainly contribute a fix for this bug, if i had te required
programming knowledge. I am not (yet!) a programmer, so i am relying 0n the
great work of the Moz engineers. (Moz is a great job after all!) It just annoys
me that the app is unpolished in some ways. This bug is easy to workaround (i
cannot imagine that it is hard for a programmer to implement a 'NEVER hide the
status bar' option) but there is NOt A SINGLE ONE of the great developers fixing
it or making a workaround, or even watching this tread. That annoys me...

No offence to anyone... I just want a 'Never hide the status bar' option so this
bug wioll never bug me again...

Comment 54

15 years ago
*** Bug 186486 has been marked as a duplicate of this bug. ***

Comment 55

14 years ago
*** Bug 189957 has been marked as a duplicate of this bug. ***

Updated

14 years ago
OS: Mac System 8.5 → MacOS X

Comment 56

14 years ago
*** Bug 191648 has been marked as a duplicate of this bug. ***

Updated

14 years ago
Blocks: 193527

Comment 57

14 years ago
*** Bug 211909 has been marked as a duplicate of this bug. ***

Comment 58

14 years ago
*** Bug 222317 has been marked as a duplicate of this bug. ***

Comment 59

14 years ago
*** Bug 225116 has been marked as a duplicate of this bug. ***

Comment 60

14 years ago
*** Bug 226503 has been marked as a duplicate of this bug. ***
*** Bug 229892 has been marked as a duplicate of this bug. ***

Comment 62

13 years ago
Created attachment 147227 [details]
No Scrollbars (OS 10.2.8)

Comment 63

13 years ago
I'm finding that on some pages there are no scrollbars at all, on others,
there's just a blank scrollbar... then some are fine.

Comment 64

13 years ago
*** Bug 235165 has been marked as a duplicate of this bug. ***
*** Bug 263328 has been marked as a duplicate of this bug. ***
*** Bug 269417 has been marked as a duplicate of this bug. ***
Product: Core → Mozilla Application Suite

Comment 67

12 years ago
Created attachment 170944 [details] [diff] [review]
patch

Makes nsNativeScrollbar care about the grow box
Attachment #170944 - Flags: review?(sfraser_bugs)

Comment 68

12 years ago
This looks OK, but what about the modern skin?

Comment 69

12 years ago
*** Bug 275236 has been marked as a duplicate of this bug. ***
Flags: blocking-seamonkey1.0a?
Assignee: firefox → joshmoz
Component: XP Apps: GUI Features → Widget: Mac
Flags: blocking-seamonkey1.0a?
Product: Mozilla Application Suite → Core
QA Contact: bugzilla → mac
Comment on attachment 170944 [details] [diff] [review]
patch

This won't work, since it resizes any scrollbar, whether or not it actually
hides behind the grow box.  I'll attach a patch that shows the issue.

What's really needed is to see if the scroll bar actually overlaps the grow
box, and only then resize it.
Attachment #170944 - Flags: review?(sfraser_bugs) → review-
Created attachment 185715 [details]
test case

In this testcase, the scrollbar in the middle of the page should span the full
document (should go off the page on the right).  And the bottom scrollbar
should look correct and have the right arrow button visible, when the status
bar is both visible and hidden (View->Status Bar).
As for fixing other themes, this is what roc suggested on IRC:

roc:	add an API to nsIWidget that nsGfxScrollFrameInner can call
        to see if it needs to reserve space, and if so, how much?
	or just to check if it needs to at all.
roc:	this API would return true if the widget has a native resizer
	then nsXULScrollFrame would have to reserve space as if there
        are two scrollbars.
	I guess this doesn't matter for nsHTMLScrollFrame since we
        currently don't allow windows to be just HTML.
*** Bug 215362 has been marked as a duplicate of this bug. ***
Adding 'hidden' to summary, to allow better search hits.
Summary: Down scroll arrow draws behind resize widget when neither Status Bar nor horizontal scrollbar are displayed → Down scroll arrow hidden, draws behind resize widget when neither Status Bar nor horizontal scrollbar are displayed

Updated

12 years ago
Blocks: 237584

Updated

12 years ago
No longer blocks: 237584

Updated

12 years ago
Blocks: 237584

Comment 75

12 years ago
*** Bug 280025 has been marked as a duplicate of this bug. ***

Comment 76

12 years ago
*** Bug 302021 has been marked as a duplicate of this bug. ***

Comment 77

12 years ago
*** Bug 319556 has been marked as a duplicate of this bug. ***
*** Bug 342751 has been marked as a duplicate of this bug. ***

Comment 79

11 years ago
*** Bug 358328 has been marked as a duplicate of this bug. ***

Comment 80

10 years ago
(In reply to comment #79)
> *** Bug 358328 has been marked as a duplicate of this bug. ***
> 

I'm running Mac OS X. 10.3.9 with Firefox 2.0.0.3 and this bug just popped up a few weeks ago. Is that any clue?

Comment 81

10 years ago
I have since moved to OS X 10.4.9 and have not seen the bug since, because of this I am removing myself from the copy list.

Updated

10 years ago
Duplicate of this bug: 379756
Duplicate of this bug: 382955

Updated

10 years ago
Blocks: 159233

Comment 84

10 years ago
With the new scrollbar implementation, would it be possible to fix this by changing the way the painting and hit-detection is mapped to and from HITheme, so that it's shorter from HITheme's perspective without Gecko having to know about it?
Moving to a component that's still relevant in 2007.
Component: Widget: Mac → Widget: Cocoa
QA Contact: mac → cocoa

Comment 86

10 years ago
YES this bug is alive and well under OSX 10.4.10, Firefox 2.0.0.6 AND Minefield 3.0a8pre.  (iBook G4) A real fix would be much appreciated by THIS user.

Recap: ONLY the 'UP' scroll arrow is visible/useable at the screen/page lower right in many/majority of web pages. (But recalling comment above, SOME pages work properly.) 

If I can understand how to u/l a small screen shot (titled no_down.png) it will show this defect appearing on THIS page. Also www.nytimes.com, etc etc.

Turning on Status Bar (View Menu) or opening a Find window cause the paired UP/DOWN scroll arrows to appear and operate properly.

Comment 87

10 years ago
Created attachment 276607 [details]
No DOWN scroll arrow

Note my comment added 14 august - Bob Tyson

Comment 88

10 years ago
The existence of this bug is well known; comments saying that it's still present aren't necessary.

Comment 89

10 years ago
I thank Mr. Morgan for his 'avviso' but would point out that I have long scratched my head at this particular Firefox defect. AND gnashed my teeth. Not a pro visitor to Bugzilla, I did what I hoped was 'due diligence' (which consumed a not small amount of my time and patience) in the FAQs, lists, and so on, before adding my notes above. I  think that not inappropriate, but would add my sincere wish that the extra email or two to those following this will NOT be read as 'hurry-up' flags, so much as 'hey, it IS still a bit of craziness' out here.

Mozilla so far as I know gets around this problem...

I note that the first FAQ in the Gran Paradiso development page says

#  What can I do to help?

We need help from developers and the testing community to provide as much feedback as possible to make Firefox even better. 

Ecco, ci qua... da Torino

Comment 90

10 years ago
Worth noting some users, like me, prefer to have the statusbar turned off (looks more mac-like, plus with fission extension the progress bar is placed with the address bar so no need for statusbar)

Instead of hide statusbar, any way to make the statusbar only take up the space underneath the scrollbar arrows? Thus pushing down arrow back up into view again
That, I think, is the plan.

Updated

10 years ago
Duplicate of this bug: 157306

Updated

9 years ago
Duplicate of this bug: 408907
Duplicate of this bug: 411229

Comment 95

9 years ago
To clarify, this bug applies to the main window and Places window in addition to the view source window.
Duplicate of this bug: 411230

Comment 97

9 years ago
Mac OS 10.5.2 Firefox 3.0b5. This has been going on for a long time in Firefox 2 as well as various beta releases.  The down scroll arrow is missing or in the same place as the expand square. It happens on all original screens using Firefox.  The down scroll arrow  usually works correctly on linked pages.
It happens whether the up arrow is at the top or the bottom of the scroll bar.  Past time to solve problem.

Comment 98

9 years ago
Don, please read

https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

especially point 1, before commenting further. Everyone is well aware that this bug is present. If it were easy to fix, it would have been done by now.

Comment 99

9 years ago
(In reply to comment #91)
> That, I think, is the plan.

Colin, when you said the above, did "that" refer to the immediately preceding comment (comment 90), or to Stuart's comment 84, or to something else entirely?

What *is* the current plan for this, in other words? I'm assuming the stuff from 2005 and earlier isn't still relevant now.

Comment 100

9 years ago
I think the plan was to fix this in bug 363757. 
(Assignee)

Updated

9 years ago
Duplicate of this bug: 434765
I think the plan then was to fix it as Mr. Lizard described it.

I don't know what the plan is now, I haven't been involved in Gecko development since January 2008.

Comment 103

9 years ago
On my 17" screen, MAC 10.5, the down arrow and the resize widget are
separate and the horizontal scroll bar appears when the vertical area 
is full or less and the horizontal area is about 3/4 of the available 
space or less.  The Status Bar is unchecked. The problem seems to occur on a fuller horizontal screen and when an original page like  this one is opened. 
Or, as you expand with  the resize widget one or both problems appear.
It usually, although occasionally, doesn't happen on linked pages.

Updated

9 years ago
Duplicate of this bug: 387259

Comment 105

9 years ago
It appears the vertical down arrow has been solved by the latest revision of Firefox 3.0.1.  The horizontal scroll bar still disappears when more than about 3/4 of the screen is used including this page.

Updated

9 years ago
Duplicate of this bug: 447953

Updated

9 years ago
Duplicate of this bug: 413308

Updated

9 years ago
Duplicate of this bug: 426704

Updated

9 years ago
Duplicate of this bug: 428504

Updated

9 years ago
Duplicate of this bug: 434889
(Assignee)

Comment 111

9 years ago
Created attachment 332529 [details] [diff] [review]
fix v0.1

This fixes it for nsGfxScrollFrames.

Roc, where should I look if I want to fix it for trees, too? I haven't been able to find the right place yet.
Assignee: joshmoz → mstange
Attachment #170944 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #332529 - Flags: review?(roc)
(Assignee)

Comment 112

9 years ago
Created attachment 332531 [details] [diff] [review]
the real fix v0.1

Oops. One check is enough.
Attachment #332529 - Attachment is obsolete: true
Attachment #332531 - Flags: review?(roc)
Attachment #332529 - Flags: review?(roc)
(Assignee)

Comment 113

9 years ago
Created attachment 332534 [details] [diff] [review]
the real real fix v0.1

Sorry for the noise. I really shouldn't trust myself.
Attachment #332531 - Attachment is obsolete: true
Attachment #332534 - Flags: review?(roc)
Attachment #332531 - Flags: review?(roc)
(Assignee)

Comment 114

9 years ago
Created attachment 332564 [details] [diff] [review]
fix v1.0: rev nsIWidget uuid
Attachment #332534 - Attachment is obsolete: true
Attachment #332564 - Flags: review?(roc)
Attachment #332534 - Flags: review?(roc)
(In reply to comment #111)
> Roc, where should I look if I want to fix it for trees, too? I haven't been
> able to find the right place yet.

Heh, I wasn't CCed on the bug :-)

Trees are in layout/xul/base/src/tree/src.
Hmm.

This approach is a bit strange. So if the viewport has no scrollbar (say the HTML document is overflow:hidden), but you position an overflow:scroll child element so that it has a vertical scrollbar whose down-arrow happens to be at the bottom-right of the window, then we'll tweak its scrollbar to be shorter.

But, if you put the element somewhere away from the window edge, then scroll the overflow:hidden window (e.g. by setting scrollTop/scrollLeft from JS) so that the vertical scrollbar down-arrow is at the bottom-right corner of the window, there's no reflow so the scrollbar will appear under the resizer. So we'd need to do something on scrolling to fix up any scrollbar ends that appeared under the resizer. Which seems weird.

It's also weird that if a vertical scrollbar overlaps the resizer horizontally, then we'll shorten it, but if it misses the resizer horizontally then it will suddenly snap out to its full height (possibly outside the window).

Yet it seems that this behaviour is exactly what Safari does...
Created attachment 332620 [details]
testcase
Maybe the issue of scrolling causing an element's scrollbar to fall under the resizer is not worth worrying about and we should just take this patch.
(Assignee)

Comment 119

9 years ago
(In reply to comment #115)
> Trees are in layout/xul/base/src/tree/src.

Yeah, but where does the scrollbar layout happen? In nsTreeBodyFrame.cpp the scrollbar's attributes (curpos, maxpos, increment, pageincrement) are updated, but I can't see the scrollbar rects anywhere.

(In reply to comment #118)
> Maybe the issue of scrolling causing an element's scrollbar to fall under the
> resizer is not worth worrying about

That's what I thought. When scrolling causes an element's scrollbar to fall under the resizer, there's usually another scrollbar covering that scrollbar.
+NS_IMETHODIMP nsChildView::AdjustScrollbar(nsRect &aScrollbarRect, PRBool aVertical)

Make this nsIntRect. I'd also prefer to make it a pointer to a rect to make it clear that it's in/out.

+  float overlapWidth = corner.x - (bounds.width - resizeIndicatorSize.width);
+  float overlapHeight = [topLevelView isFlipped] ?
+                        corner.y - (bounds.height - resizeIndicatorSize.height) : 
+                        resizeIndicatorSize.height - corner.y;
+
+  if (overlapWidth > 0.0f && overlapHeight > 0.0f) {

I think it would be more clear if we just computed the intersection of the resizer rect with the scrollbar rect and tested whether they intersect. That would also handle potential bidi situations where the scrollbar is on the left.

+  if ((aVertical && !aRect.width) || (!aVertical && !aRect.height))

if ((aVertical ? aRect.width : aRect.height) == 0)

The rounding issues here are nasty. I think it might make more sense for nsIWidget to return a pixel-rect containing the resizer area, then we can convert that to appunits and adjust the scrollbar rect in AdjustScrollbarRect.
(In reply to comment #119)
> (In reply to comment #115)
> > Trees are in layout/xul/base/src/tree/src.
> 
> Yeah, but where does the scrollbar layout happen? In nsTreeBodyFrame.cpp the
> scrollbar's attributes (curpos, maxpos, increment, pageincrement) are updated,
> but I can't see the scrollbar rects anywhere.

Hmm. I think maybe there's an XBL binding for <tree> that creates a standalone XUL scrollbar which uses nsIScrollbarMediator to manage scrolling for the tree? That sounds even harder. I'd tackle that separately, if at all.

Comment 122

9 years ago
Curious, to me this does not happen under Thunderbird. 
With the page recized to the bottom of the screen the vertical down arrow is separate from the recizer on Mac Leopard as it should be.

 When the recizer is about 1/2 across the screen the horizontal scroll bar is there. As the recizer is pulled to the right the grey  bar gets longer until it reaches the right end of the space available. Then as the resizer is moved further right the horizontal scroll bar and scroll arrow disappears.
(Assignee)

Comment 123

9 years ago
Created attachment 332744 [details] [diff] [review]
fix v2.0

Like this?

(In reply to comment #121)
> Hmm. I think maybe there's an XBL binding for <tree> that creates a standalone
> XUL scrollbar which uses nsIScrollbarMediator to manage scrolling for the tree?

Uh yeah, I think that's it. Thanks.
Attachment #332564 - Attachment is obsolete: true
Attachment #332744 - Flags: review?(roc)
Attachment #332564 - Flags: review?(roc)
(Assignee)

Comment 124

9 years ago
Comment on attachment 332744 [details] [diff] [review]
fix v2.0

The logic in AdjustScrollbarRect can only deal with resizers in the bottom right corner but I think that's enough until we discover an OS that puts it somewhere else.
Comment on attachment 332744 [details] [diff] [review]
fix v2.0

+     * Ignored on any platform that does not support it.

"Returns false on..."
Attachment #332744 - Flags: superreview+
Attachment #332744 - Flags: review?(roc)
Attachment #332744 - Flags: review+
(Assignee)

Comment 126

9 years ago
Created attachment 332919 [details] [diff] [review]
fix comment
Attachment #332744 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Keywords: helpwanted → checkin-needed

Comment 127

9 years ago
attachment #332919 [details] [diff] [review] pushed for Markus:

http://hg.mozilla.org/mozilla-central/index.cgi/rev/ca7df626c426
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed → verifyme
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
(Assignee)

Comment 128

9 years ago
Comment on attachment 332919 [details] [diff] [review]
fix comment

Camino needs this (bug 159233).
Attachment #332919 - Flags: approval1.9.0.2?
Can this code be tested? At the very least, can the layout code be tested? I'd prefer to see some tests before considering this for 1.9.0.x. It also needs to bake for a while...
Flags: in-testsuite?
(Assignee)

Comment 130

9 years ago
I don't know - roc, can it be tested? Maybe with a mochitest that opens a new dialog, puts an overflow:auto box in the corner, synthesizes a mouseclick on the corner and checks if the box has been scrolled?
(Assignee)

Comment 131

9 years ago
Actually, that sounds possible. I'll try it.
Just make sure the test still works even if the test machine has non-default settings for where the scroll arrows go.

Another option is to use canvas.drawWindow in mochitest to do a "manual" reftest of the appearance of a window with resizer.
Comment on attachment 332919 [details] [diff] [review]
fix comment

Moving approval request out. This should probably get more baking before landing in 1.9.0.x and should also have a few tests.
Attachment #332919 - Flags: approval1.9.0.2? → approval1.9.0.3?
(Assignee)

Updated

9 years ago
Depends on: 451641
(Assignee)

Comment 134

9 years ago
Comment on attachment 332919 [details] [diff] [review]
fix comment

This caused bug 451641, so I'm removing the approval request for now.
Attachment #332919 - Flags: approval1.9.0.3?
Duplicate of this bug: 457378

Updated

9 years ago
Duplicate of this bug: 451559

Updated

9 years ago
Duplicate of this bug: 457740

Updated

9 years ago
Duplicate of this bug: 457740

Updated

8 years ago
Duplicate of this bug: 468019
Depends on: 461865

Comment 140

8 years ago
Created attachment 361209 [details]
Screenshot snippets showing the problem (FF 3.0.6)

Comment 141

8 years ago
See attachment 361209 [details]. This issue is not resolved in FF 3.0.6 (and remained a problem all through 2.X). System is OS X 10.4, problem occurs regardless of whether or not scroll buttons are grouped in System Preferences -> Appearance. Should be a simple fix by drawing on the same code that positions both scrollbars under X && Y overflow to position scrollbars under X only, or Y only overflow.
(Assignee)

Comment 142

8 years ago
This bug won't be fixed in any Firefox 3.0 version. It's fixed in the 3.1 Betas you can get here: http://www.mozilla.com/en-US/firefox/all-beta.html
(Assignee)

Updated

8 years ago
Duplicate of this bug: 481420
(Assignee)

Updated

8 years ago
Duplicate of this bug: 501055

Updated

8 years ago
Duplicate of this bug: 488471
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.