Closed
Bug 564970
Opened 14 years ago
Closed 14 years ago
Make /language-tools faster
Categories
(addons.mozilla.org Graveyard :: Code Quality, defect)
addons.mozilla.org Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
5.11.4
People
(Reporter: clouserw, Assigned: davedash)
References
()
Details
(Whiteboard: [z][loadtest+][qa-])
This is slower than remora: 9r/s vs 1r/s https://wiki.mozilla.org/User:Clouserw/AMO/loadtest#.2Flanguage-tools
Reporter | ||
Updated•14 years ago
|
Target Milestone: 5.11 → 5.12
Reporter | ||
Comment 1•14 years ago
|
||
This was written long ago and we've gotten better at optimization since. Can you look at how we're drawing the other listing pages and copy the good stuff from there?
Assignee: nobody → dd
Target Milestone: 5.12 → 5.11.4
Comment 2•14 years ago
|
||
This page pulls in a lot of add-ons (120 for me locally) so it might be getting bogged down unpickling all those from cache (along with their attached versions, applications, users, etc.). It would probably be fruitful to pare down the dataset this page works with once it's in cache.
Assignee | ||
Comment 3•14 years ago
|
||
I get the same thing, I'm querying using the appsupport table instead, but still I get ~120 addons. Open to suggestions here. Can I just do a no_transform? We probably don't need the versions/files/etc. http://github.com/davedash/zamboni/compare/master...speed-language-564970
Comment 4•14 years ago
|
||
.only_translations() would go better. That page has file sizes, which need to hop across versions to get to files. I'm guessing that getting all you need, sticking it in a dict, and using cached_with on that will save a lot of time. Or maybe template caching would be good enough?
Assignee | ||
Comment 5•14 years ago
|
||
Wil, I just pushed this: http://github.com/jbalogh/zamboni/commits/ef9f1e2 Feel free to load test and see if it does any better. I wanted to use template caching, but the view ends up doing a lot of stuff which causes the addons to be loaded in the view not the template.
Reporter | ||
Comment 6•14 years ago
|
||
Requests per second: 3.57 [#/sec] (mean) Still needs work. It sounds like we should go for a slow first load and then heavy caching
Assignee | ||
Comment 7•14 years ago
|
||
jbalogh, any idea why _get_locales doesn't appear to be as cached as it could be?
Comment 8•14 years ago
|
||
Sprinkled a little generator on this in http://github.com/jbalogh/zamboni/commits/5ee9be1. I think the set of 120 objects was too big to slide into memcached.
Updated•14 years ago
|
Whiteboard: [z][loadtest?]
Reporter | ||
Comment 9•14 years ago
|
||
This went slowly at first, but sped pretty quickly. Unfortunately, ab sucks and died at 590/600. So, I ran it again and it was still super fast, so once it's in cache it looks great. Thanks! Requests per second: 84.57 [#/sec] (mean)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [z][loadtest?] → [z][loadtest+]
Updated•14 years ago
|
Whiteboard: [z][loadtest+] → [z][loadtest+][qa-]
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•